Summary

Cleaning up a bunch of ymfm warnings:

• One such warning revolved around the YMF278B implementation. The index was based around a ternary which made gcc unhappy. Cleaned up by matching the official example (existing code did not match)
• Another issue was cleaned up by adding a conditional to make gcc happy (this one resulted in several warnings)

In addition, all sprintfs were cleaned up to snprintfs to make clang happy. Since ymfm uses pointer arithmetic to write to the buffer a special macro had to be created to be passed to snprintf and properly calculate the remaining size. You'll see the macro as SNPRINTF_BUFFER_SIZE_CALC.

Checklist

• I have discussed this with core contributors already

References

N/A