serial_passthrough: Allow configuration of named pipe parameter #3111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhrdlicka
requested changes
Feb 15, 2023
c17511b to
17cc3d0
Compare
dhrdlicka
reviewed
Feb 15, 2023
17cc3d0 to
02101e3
Compare
dhrdlicka
reviewed
Feb 15, 2023
src/win/win_serial_passthrough.c
Outdated
Comment on lines
170
to
173
| if (strnicmp("\\\\.\\pipe\\", ascii_pipe_name, sizeof("\\\\.\\pipe\\") - 1)) { | ||
| ui_msgbox(MBX_WARNING, L"Serial Passthrough: Pipe name is invalid."); | ||
| return 0; | ||
| } |
Contributor
There was a problem hiding this comment.
IMHO this condition is redundant as long as we properly handle CreateNamedPipe errors.
| if (dev->master_fd == (intptr_t) INVALID_HANDLE_VALUE) { | ||
| return 0; |
Contributor
There was a problem hiding this comment.
We could show a message box here with the error information obtained via GetLastError instead.
02101e3 to
8235a0c
Compare
4b6ee4a to
3050dae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
serial_passthrough: Allow configuration of named pipe parameter
Windows-only.
Checklist
References
None.