qt: Various fields should not be editable in settings view #3084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can this fix be extended to other table views (floppy, CD-ROM, etc.) in the settings dialog? They seem to exhibit the same problem. |
Contributor
Author
|
Good catch, I didn't even check the others! I'm also seeing it in:
Are you seeing it anywhere else in settings? |
Contributor
|
No, it's just the pages you mentioned. |
3 tasks
Contributor
Author
|
Thanks, I added those as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When viewing the hard drive listing in the settings view, you can double click some of the fields and edit them. This disables the editable aspect of those fields (they shouldn't be editable).
Edit: Added the same fix for floppy, cd-rom, and other devices after @lemondrops brought it to my attention.
Checklist
References
N/A