Add ALi M1435 southbridge and three new machines #3024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Contributor
|
the entire out directory isn't needed and should be removed also, ali1429.c and ali1435.c will have to be updated to the new code style (though I suppose @jriwanek will take care of that?) |
Contributor
Author
I assume you're talking about the files generated by Visual Studio? If yes, I should have cleared those. My bad.
The codes for those come from OBattler, perhaps they will be updated? |
Contributor
I was referring to the indentation style, which seems to still be the old tabs-spaces mix. |
Member
|
Yup. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed ALi M1429G northbridge and added M1435 southbridge code from OBattler
Added MSI MS-4134 (machines/ms4134/4alm001.bin)
Added TriGem 486GP (machines/tg486gp/tg486gp.bin)
Added TriGem 486G (machines/tg486g/tg486g.bin)
NOTE: 486G needs some fixes regarding cache and CMOS setup before release.
Checklist
References
All fixes and new codes for both the chipsets and the machines are from OBattler, which I'm PRing at the request of him.