Skip to content

fix build for non-dynarec platforms #2896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OBattler merged 1 commit into from
Nov 30, 2022
Merged

fix build for non-dynarec platforms #2896

OBattler merged 1 commit into from
Nov 30, 2022

Conversation

@sharkcz
Copy link

@sharkcz sharkcz commented Nov 26, 2022

Summary

Do not set a member that doesn't exist on platforms without dynarec support. Currently it fails to build with

/builddir/build/BUILD/86Box-3.11/src/cpu/cpu.c: In function 'cpu_set':
/builddir/build/BUILD/86Box-3.11/src/cpu/cpu.c:1173:17: error: 'x86_dynarec_opcodes_3DNOW' undeclared (first use in this function); did you mean 'x86_opcodes_3DNOW'?
 1173 |                 x86_dynarec_opcodes_3DNOW = dynarec_ops_3DNOWE;
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~
      |                 x86_opcodes_3DNOW
/builddir/build/BUILD/86Box-3.11/src/cpu/cpu.c:1173:17: note: each undeclared identifier is reported only once for each function it appears in
builddir/build/BUILD/86Box-3.11/src/cpu/cpu.c:1173:45: error: 'dynarec_ops_3DNOWE' undeclared (first use in this function)
 1173 |                 x86_dynarec_opcodes_3DNOW = dynarec_ops_3DNOWE;
      |                                             ^~~~~~~~~~~~~~~~~~

Checklist

References

Provide links to datasheets or other documentation that helped you implement this pull request.

@sharkcz
Copy link
Author

sharkcz commented Nov 26, 2022

The build system is Fedora 36 (and Rawhide) on ppc64le.

@OBattler OBattler merged commit 9b73f1a into 86Box:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sharkcz @OBattler