Skip to content

Fix two warnings in Qt code#2618

Merged
OBattler merged 1 commit into
86Box:masterfrom
lemondrops:bugfix/warnings
Aug 13, 2022
Merged

Fix two warnings in Qt code#2618
OBattler merged 1 commit into
86Box:masterfrom
lemondrops:bugfix/warnings

Conversation

@lemondrops

@lemondrops lemondrops commented Aug 13, 2022

Copy link
Copy Markdown
Contributor

Summary

Fixes the following warnings:

In file included from C:/Jenkins/agent/workspace/86Box@9/src/qt/qt_openglrenderer.cpp:27:
C:/Jenkins/agent/workspace/86Box@9/src/qt/qt_openglrenderer.hpp: In constructor 'OpenGLRenderer::OpenGLRenderer(QWidget*)':
C:/Jenkins/agent/workspace/86Box@9/src/qt/qt_openglrenderer.hpp:81:20: warning: 'OpenGLRenderer::renderTimer' will be initialized after [-Wreorder]
   81 |     QTimer        *renderTimer;
      |                    ^~~~~~~~~~~
C:/Jenkins/agent/workspace/86Box@9/src/qt/qt_openglrenderer.hpp:80:20: warning:   'OpenGLOptions* OpenGLRenderer::options' [-Wreorder]
   80 |     OpenGLOptions *options;
      |                    ^~~~~~~
C:/Jenkins/agent/workspace/86Box@9/src/qt/qt_openglrenderer.cpp:37:1: warning:   when initialized here [-Wreorder]
   37 | OpenGLRenderer::OpenGLRenderer(QWidget *parent)
      | ^~~~~~~~~~~~~~
C:/Jenkins/agent/workspace/86Box@9/src/qt/qt_openglrenderer.cpp: In member function 'void OpenGLRenderer::initializeExtensions()':
C:/Jenkins/agent/workspace/86Box@9/src/qt/qt_openglrenderer.cpp:257:29: warning: operation on '((OpenGLRenderer*)this)->OpenGLRenderer::glBufferStorage' may be undefined [-Wsequence-point]
  257 |             glBufferStorage = glBufferStorage = (PFNGLBUFFERSTORAGEEXTPROC_LOCAL) context->getProcAddress("glBufferStorage");
      |             ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Note: no action was taken on the unused int combo_to_struct[256]; in qt_deviceconfig.cpp because this seems to be reserved for future use; paging @jriwanek for clarifcation.

Checklist

  • I have discussed this with core contributors already
  • This pull request requires changes to the ROM set

@OBattler OBattler merged commit fc70514 into 86Box:master Aug 13, 2022
@lemondrops lemondrops deleted the bugfix/warnings branch August 14, 2022 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants