Skip to content
/ utils Public

Use go-shellcheck instead of local one for pre-commit#679

Merged
5ouma merged 2 commits intomainfrom
chore-pre-commit-go-shellcheck
Jan 26, 2026
Merged

Use go-shellcheck instead of local one for pre-commit#679
5ouma merged 2 commits intomainfrom
chore-pre-commit-go-shellcheck

Conversation

@5ouma
Copy link
Owner

@5ouma 5ouma commented Jan 26, 2026

No need to install ShellCheck locally.

5ouma added 2 commits January 26, 2026 14:13
@5ouma
chore(pre-commit): Use go-shellcheck instead of local one
bf1ac61 
No need to install ShellCheck locally.

Signed-off-by: Souma <git@5ouma.me>
@5ouma
chore(pre-commit): Add go-shellcheck as a dependency of actionlint
a405faf 
It will use ShellCheck for better audition.

Signed-off-by: Souma <git@5ouma.me>
Copilot AI review requested due to automatic review settings January 26, 2026 05:15
@github-actions github-actions bot added the 🚸 pre-commit Check the code with pre-commit hooks label Jan 26, 2026
Copilot AI reviewed Jan 26, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the pre-commit configuration by replacing the need for a local ShellCheck installation with the Go-based go-shellcheck implementation from wasilibs. This change makes the setup more portable and easier to maintain since Go dependencies can be automatically managed by pre-commit.

Changes:

  • Added go-shellcheck as an additional dependency to the actionlint hook to enable shell script linting in GitHub Actions workflows
  • Replaced the remote pre-commit-shell repository with a local go-shellcheck-based hook configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai
Copy link

coderabbitai bot commented Jan 26, 2026

Walkthrough

The .pre-commit-config.yaml file is updated to replace an external shell linting repository with a local shellcheck hook configuration, while adding explicit language and dependency declarations to both the actionlint and new shellcheck hooks.

Changes

Cohort / File(s) Summary
Pre-commit configuration
.pre-commit-config.yaml		 Replaces detailyang/pre-commit-shell external repo with local shellcheck hook; renames hook from shell-lint to shellcheck; adds language: golang and additional_dependencies: [shellcheck@v0.11.1] to both actionlint and shellcheck hooks; augments shellcheck with name, description, entry, and types: [shell] metadata

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: switching from a local shellcheck setup to go-shellcheck for pre-commit hooks, which aligns with the changeset modifications.
Description check ✅ Passed The description is related to the changeset, explaining the motivation (avoiding local ShellCheck installation) behind using go-shellcheck instead, though it lacks detail about the implementation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore-pre-commit-go-shellcheck

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@5ouma 5ouma merged commit 8affee0 into main Jan 26, 2026
11 checks passed
@5ouma 5ouma deleted the chore-pre-commit-go-shellcheck branch January 26, 2026 05:24
@5ouma 5ouma bot mentioned this pull request Jan 26, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

@5ouma 5ouma

Labels

🚸 pre-commit Check the code with pre-commit hooks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@5ouma