Skip to content
/ utils Public

Ignore pre-commit all signing log from environment variable#665

Merged
5ouma merged 1 commit intomainfrom
fix-pre-commit-git-commit-log-parameter
Jan 21, 2026
Merged

Ignore pre-commit all signing log from environment variable#665
5ouma merged 1 commit intomainfrom
fix-pre-commit-git-commit-log-parameter

Conversation

@5ouma
Copy link
Owner

@5ouma 5ouma commented Jan 21, 2026

Hide all signing messages not from CLI flags.

@5ouma
fix(pre-commit): Ignore all signing log from environment variable
91d66d9 
Hide all signing messages not from CLI flags.
Copilot AI review requested due to automatic review settings January 21, 2026 01:40
@github-actions github-actions bot added the 🚸 pre-commit Check the code with pre-commit hooks label Jan 21, 2026
Copilot AI reviewed Jan 21, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR changes the method of suppressing git signature logs from using a command-line flag to using an environment variable, making the configuration apply to all git commands in the script.

Changes:

  • Added GIT_CONFIG_PARAMETERS environment variable export to globally suppress git signature logs
  • Removed the -c log.showSignature=false CLI flag from the git log command

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai
Copy link

coderabbitai bot commented Jan 21, 2026

Walkthrough

The script pre-commit/scripts/upload-git-commit-notion was refactored to apply git configuration via an environment variable instead of per-invocation command-line parameters. An exported GIT_CONFIG_PARAMETERS variable now globally sets log.showSignature=false, replacing the inline -c flag previously used in the git log command.

Changes

Cohort / File(s) Summary
Git configuration refactoring
pre-commit/scripts/upload-git-commit-notion		 Added GIT_CONFIG_PARAMETERS environment variable export for log.showSignature=false. Removed per-call -c log.showSignature=false parameter from git log invocation. Shifts configuration application from command-level to environment-level.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: exporting GIT_CONFIG_PARAMETERS to ignore git signing logs via environment variable instead of per-invocation CLI flags.
Description check ✅ Passed The description is related to the changeset, explaining the intent to hide signing messages from environment variables rather than CLI flags.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-pre-commit-git-commit-log-parameter

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@5ouma 5ouma merged commit c28b247 into main Jan 21, 2026
11 checks passed
@5ouma 5ouma deleted the fix-pre-commit-git-commit-log-parameter branch January 21, 2026 01:42
@5ouma 5ouma bot mentioned this pull request Jan 21, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

@5ouma 5ouma

Labels

🚸 pre-commit Check the code with pre-commit hooks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@5ouma