Skip to content
/ utils Public

Use pre-commit script instead of unsupported_script#662

Merged
5ouma merged 1 commit intomainfrom
style-pre-commit-unsupported-script
Jan 21, 2026
Merged

Use pre-commit script instead of unsupported_script#662
5ouma merged 1 commit intomainfrom
style-pre-commit-unsupported-script

Conversation

@5ouma
Copy link
Owner

@5ouma 5ouma commented Jan 21, 2026

prek uses it as the default.

Copilot AI review requested due to automatic review settings January 21, 2026 00:48
@github-actions github-actions bot added the 🚸 pre-commit Check the code with pre-commit hooks label Jan 21, 2026
Copilot AI reviewed Jan 21, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the pre-commit hook configuration to use the modern script language type instead of the deprecated unsupported_script type, aligning with current pre-commit framework conventions.

Changes:

  • Updated language field from unsupported_script to script in the pre-commit hook definition

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai
Copy link

coderabbitai bot commented Jan 21, 2026

Walkthrough

The pre-commit hook configuration for upload-git-commit-notion is updated to change the language field from unsupported_script to script, aligning the hook declaration with supported script execution modes.

Changes

Cohort / File(s) Change Summary
Pre-commit hook language update
.pre-commit-hooks.yaml		 Updated language field for upload-git-commit-notion hook from unsupported_script to script

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and clearly summarizes the main change: replacing unsupported_script with script in the .pre-commit-hooks.yaml file.
Description check ✅ Passed The description relates to the changeset by explaining the rationale that 'prek uses it as the default', providing context for why this change is being made.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch style-pre-commit-unsupported-script

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@5ouma 5ouma changed the title Use script instead of unsupported_script Use pre-commit script instead of unsupported_script Jan 21, 2026
@5ouma 5ouma merged commit 39cfcc6 into main Jan 21, 2026
11 checks passed
@5ouma 5ouma deleted the style-pre-commit-unsupported-script branch January 21, 2026 00:52
@5ouma 5ouma bot mentioned this pull request Jan 20, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

@5ouma 5ouma

Labels

🚸 pre-commit Check the code with pre-commit hooks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@5ouma