Conversation
It will break commit hash get logic.
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where Git commit signature verification messages interfere with parsing commit hashes in the upload-git-commit-notion pre-commit hook script. The fix adds a git configuration parameter to suppress signature display when retrieving commit hashes.
- Adds
-c log.showSignature=falseflag to the git log command to hide signature verification output
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
WalkthroughModified the git log invocation in a script to suppress signature verification output by adding the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pre-commit/scripts/upload-git-commit-notion (1)
42-42: Apply-c log.showSignature=falseconsistently to all git log commands for robustness.Lines 17-19 should also include the
-c log.showSignature=falseflag alongside line 42 for consistency. While the impact only manifests with GPG-signed commits (which are not present in the current repository), applying the flag uniformly ensures the script extracts clean data regardless of signature configuration. This prevents potential JSON corruption if message, description, or date fields are contaminated by signature output.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pre-commit/scripts/upload-git-commit-notion
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Upload results
- GitHub Check: 🚸 pre-commit
It will break the commit hash get logic.