Conversation
This reverts commit d94f12f.
There was a problem hiding this comment.
Pull request overview
This PR reverts a previous commit to remove the pinact and ghalint pre-commit hooks from the repository's utilities.
Key Changes:
- Removed three pre-commit hook definitions (pinact, ghalint, ghalint-act) from
.pre-commit-hooks.yaml - Updated the README documentation to remove examples of the deleted hooks and changed default hook types
- Modified Renovate configuration's managerFilePatterns to narrow scope from regex to specific filename
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.pre-commit-hooks.yaml |
Removed definitions for pinact, ghalint, and ghalint-act hooks (30 lines deleted) |
README.md |
Removed hook examples from documentation and removed "pre-commit" from default_install_hook_types |
.github/renovate.json |
Changed managerFilePatterns from regex pattern to single filename |
Comments suppressed due to low confidence (1)
.github/renovate.json:25
- The managerFilePatterns was changed from an array containing a regex pattern to an array with a single filename. However, the matchStrings on line 22 is still looking for pinact and ghalint dependencies. Since these hooks have been removed from .pre-commit-hooks.yaml, this regex pattern will never match anything and should also be removed, or the entire customManager entry should be deleted.
{
"customType": "regex",
"managerFilePatterns": [".pre-commit-config.yaml"],
"matchStrings": [
"(?<depName>github.com/suzuki-shunsuke/(pinact|ghalint))(/v(?<major>[0-9]+))?/cmd/(pinact|ghalint)@(?<currentValue>v[0-9]+\\.[0-9]+\\.[0-9]+)"
],
"datasourceTemplate": "go"
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughNarrowed Renovate file-match pattern to the exact Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This reverts commit d94f12f.