Skip to content
/ utils Public

Remove the duplicated double quote from pre-commit action#524

Merged
5ouma merged 2 commits intomainfrom
fix-pre-commit-shell-syntax
Nov 22, 2025
Merged

Remove the duplicated double quote from pre-commit action#524
5ouma merged 2 commits intomainfrom
fix-pre-commit-shell-syntax

Conversation

@5ouma
Copy link
Owner

@5ouma 5ouma commented Nov 22, 2025

It broke the shell syntax to be run.

@github-actions github-actions bot added the 🚸 pre-commit Check the code with pre-commit hooks label Nov 22, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 22, 2025

Walkthrough

This PR fixes a shell command quoting error in the cleanup step by removing an extraneous trailing quote from a variable reference, changing rm "$PREK_CONFIG"" to rm "$PREK_CONFIG" to restore valid shell syntax.

Changes

Cohort / File(s) Summary
Shell script syntax fix
pre-commit/action.yml		 Removed extraneous trailing quote from cleanup command to restore valid shell syntax

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing a duplicated double quote from the pre-commit action file.
Description check ✅ Passed The description is related to the changeset, explaining that the fix addresses broken shell syntax caused by the duplicated quote.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-pre-commit-shell-syntax
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4a1a7e3 and cb6ab74.

📒 Files selected for processing (1)
  • pre-commit/action.yml (1 hunks)
🔇 Additional comments (1)
pre-commit/action.yml (1)

56-56: ✓ Shell syntax fix is correct.

The removal of the extraneous trailing double quote restores valid shell syntax. The variable reference "$PREK_CONFIG" is properly quoted and aligns with the variable definition in the env section below.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@5ouma 5ouma merged commit 02d9ca4 into main Nov 22, 2025
5 checks passed
@5ouma 5ouma deleted the fix-pre-commit-shell-syntax branch November 22, 2025 03:19
@5ouma 5ouma bot mentioned this pull request Nov 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

@5ouma 5ouma

Labels

🚸 pre-commit Check the code with pre-commit hooks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@5ouma