Skip to content
/ utils Public

Use prek built-in hooks instead of pre-commit original one#522

Merged
5ouma merged 2 commits intomainfrom
chore-pre-commit-prek-builtin
Nov 23, 2025
Merged

Use prek built-in hooks instead of pre-commit original one#522
5ouma merged 2 commits intomainfrom
chore-pre-commit-prek-builtin

Conversation

@5ouma
Copy link
Owner

@5ouma 5ouma commented Nov 22, 2025

They're much faster to run and prepare.

@5ouma
chore(pre-commit): Use prek built-in hooks instead of pre-commit orig…
fafca22 
…inal one

They're much faster to run and prepare.
@github-actions github-actions bot added the 🚸 pre-commit Check the code with pre-commit hooks label Nov 22, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 22, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

pre-commit configuration updated: moved trailing-whitespace and end-of-file-fixer from an external repo into the builtin repo, added check-merge-conflict, detect-private-key, and check-executables-have-shebangs, and preserved existing JSON/TOML/YAML checks and the Lucas-C/pre-commit-hooks external repo.

Changes

Cohort / File(s) Summary
Pre-commit hooks consolidation
\.pre-commit-config\.yaml		 Reorganized hooks: expanded builtin repository hook list, migrated trailing-whitespace and end-of-file-fixer from an external repo to builtin, added check-merge-conflict, detect-private-key, and check-executables-have-shebangs, and kept existing check-json, check-toml, check-yaml plus the Lucas-C/pre-commit-hooks external entry.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify hook IDs and repository sources are correct (builtin vs external).
  • Confirm migrated hooks preserve any configuration (args, exclusions).
  • Validate new hooks' intended behavior and file match patterns.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title contains a typo ('prek' instead of 'pre-commit') and is unclear, but it does relate to the main change of switching to built-in hooks. Correct the typo to 'Use pre-commit built-in hooks instead of pre-commit original one' for clarity.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The description is related to the changeset, providing a rationale (faster performance) for switching to built-in hooks.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fafca22 and f0b96b8.

📒 Files selected for processing (1)
  • .pre-commit-config.yaml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@5ouma 5ouma merged commit 5c8a362 into main Nov 23, 2025
4 of 5 checks passed
@5ouma 5ouma deleted the chore-pre-commit-prek-builtin branch November 23, 2025 23:58
@5ouma 5ouma bot mentioned this pull request Nov 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

@5ouma 5ouma

Labels

🚸 pre-commit Check the code with pre-commit hooks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@5ouma