Skip to content
/ utils Public

Don't pass file names to Git commit upload hook#509

Merged
5ouma merged 2 commits intomainfrom
fix-pre-commit-upload-git-commit-notion-pass-filenames
Nov 17, 2025
Merged

Don't pass file names to Git commit upload hook#509
5ouma merged 2 commits intomainfrom
fix-pre-commit-upload-git-commit-notion-pass-filenames

Conversation

@5ouma
Copy link
Owner

@5ouma 5ouma commented Nov 17, 2025

It's not needed to pass the file names.

@5ouma
fix(pre-commit): Don't pass file names to Git commit upload hook
c4e92c8 
It's not needed to be passed the file names.
@coderabbitai
Copy link

coderabbitai bot commented Nov 17, 2025 •
edited
Loading

Walkthrough

Added pass_filenames: false to the upload-git-commit-notion pre-commit hook, so the hook will no longer receive the list of changed filenames when executed (e.g., during pre-push).

Changes

Cohort / File(s) Summary
Pre-commit hook configuration
\.pre-commit-hooks.yaml		 Added pass_filenames: false to the upload-git-commit-notion hook configuration, changing its input behavior so it does not receive changed filenames

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single configuration flag change with predictable behavior
  • Check that the hook implementation safely handles being invoked without filename arguments (pre-push flows)

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding pass_filenames: false to the Git commit upload hook, preventing filenames from being passed to it.
Description check ✅ Passed The description is brief but directly related to the changeset, explaining that passing file names is not needed for the upload hook.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-pre-commit-upload-git-commit-notion-pass-filenames
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c4e92c8 and 7ace06d.

📒 Files selected for processing (1)
  • .pre-commit-hooks.yaml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .pre-commit-hooks.yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@5ouma 5ouma merged commit 6c7547e into main Nov 17, 2025
5 checks passed
@5ouma 5ouma deleted the fix-pre-commit-upload-git-commit-notion-pass-filenames branch November 17, 2025 13:39
@5ouma 5ouma added the 🚸 pre-commit Check the code with pre-commit hooks label Nov 17, 2025
@5ouma 5ouma bot mentioned this pull request Nov 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

@5ouma 5ouma

Labels

🚸 pre-commit Check the code with pre-commit hooks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@5ouma