Skip to content

Specify the PR author name#274

Merged
5ouma merged 2 commits intomainfrom
ci/update-lock/pr-author
Aug 1, 2025
Merged

Specify the PR author name#274
5ouma merged 2 commits intomainfrom
ci/update-lock/pr-author

Conversation

@5ouma
Copy link
Owner

@5ouma 5ouma commented Aug 1, 2025

⚠️ Issue

close #


✏️ Description

Use github.event.pull_request.user.login, not github.actor.

@5ouma
ci(update-lock): Specify the PR author name
29f09b4 
Use github.event.pull_request.user.login not github.actor.
Copilot AI review requested due to automatic review settings August 1, 2025 11:00
@github-actions github-actions bot added the 🎽 CI Changes to CI configuration files and scripts label Aug 1, 2025
Copilot AI reviewed Aug 1, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the GitHub Actions workflow to use the PR author's username instead of the actor's username for determining when to run the lock file update job. This ensures the workflow triggers based on who created the pull request rather than who triggered the workflow event.

  • Updates the conditional check from github.actor to github.event.pull_request.user.login

@coderabbitai
Copy link

coderabbitai bot commented Aug 1, 2025

Walkthrough

The workflow file for updating lock files was modified to change the condition that determines when the workflow runs. The check now verifies if the pull request author's login is 'renovate[bot]' instead of checking the GitHub actor.

Changes

Cohort / File(s) Change Summary
Workflow Condition Update
.github/workflows/update-lock.yml		 Modified the conditional expression to check the pull request author's login instead of the GitHub actor.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ci/update-lock/pr-author

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Aug 1, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/update-lock.yml (1)

14-14: Normalise the runner label casing.

GitHub-hosted runner labels are case-insensitive, but all official docs use lower-case (ubuntu-latest). Normalising avoids future confusion and keeps the workflow consistent with common samples.

-    runs-on: Ubuntu-Latest
+    runs-on: ubuntu-latest
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between efc5c5b and 29f09b4.

📒 Files selected for processing (1)
  • .github/workflows/update-lock.yml (1 hunks)
🔇 Additional comments (1)
.github/workflows/update-lock.yml (1)

13-13: Condition switch is correct & clearer.

Using github.event.pull_request.user.login reliably targets the PR author instead of the actor that triggered the workflow run, which prevents false-positives when Renovate pushes follow-up commits. 👍

@5ouma 5ouma enabled auto-merge (squash) August 1, 2025 11:14
@5ouma 5ouma merged commit 936d043 into main Aug 1, 2025
9 checks passed
@5ouma 5ouma deleted the ci/update-lock/pr-author branch August 1, 2025 11:15
@5ouma 5ouma bot mentioned this pull request Aug 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

@5ouma 5ouma

Labels

🎽 CI Changes to CI configuration files and scripts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@5ouma