Skip to content

Git commiter must be set on checkout#255

Merged
5ouma merged 2 commits intomainfrom
ci-tagpr-checkout-token
Jun 17, 2025
Merged

Git commiter must be set on checkout#255
5ouma merged 2 commits intomainfrom
ci-tagpr-checkout-token

Conversation

@5ouma
Copy link
Owner

@5ouma 5ouma commented Jun 17, 2025

⚠️ Issue

close #


✏️ Description

It's needed to store Git credentials even after checking out the repository.


It's needed to store Git credentials even after checking out the repository.
Copilot AI review requested due to automatic review settings June 17, 2025 13:20
@github-actions github-actions bot added the 🎽 CI Changes to CI configuration files and scripts label Jun 17, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the release workflow to use the GitHub App Token when checking out the repo so that credentials persist for later Git operations.

  • Moves the checkout step to after the App Token creation and enables persist-credentials: true
  • Removes the earlier checkout with persist-credentials: false
  • Adds a ghalint exclusion for the checkout_persist_credentials_should_be_false policy

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/release.yml Reorders and updates the checkout step to use the App Token and persist credentials
.github/ghalint.yml Adds an exclusion for the checkout_persist_credentials_should_be_false lint policy
Comments suppressed due to low confidence (2)

.github/ghalint.yml:4

  • The job_name here refers to a step ID, not the workflow job name. This exclusion may not apply correctly—either update it to the actual job key (e.g., release) or remove the exclusion if the false-checkout step has been removed.
    job_name: tagpr

.github/workflows/release.yml:29

  • [nitpick] Two steps share the same name, which can make logs confusing. Consider renaming this to something like 🚚 Checkout with App Token to clarify its purpose.
      - name: 🚚 Checkout repository

@coderabbitai
Copy link

coderabbitai bot commented Jun 17, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

A configuration file was added to exclude a specific GitHub Actions linting policy for the tagpr job in the release workflow. Additionally, the repository checkout step in the release workflow was moved to occur after a GitHub App token is generated, using this token with persisted credentials for subsequent steps.

Changes

Files/Paths Change Summary
.github/ghalint.yml Added configuration to exclude checkout_persist_credentials_should_be_false policy for the tagpr job in release.yml.
.github/workflows/release.yml Moved checkout step to after GitHub App token creation; now uses the app token with persist-credentials: true.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8e33754 and 108b051.

📒 Files selected for processing (1)
  • .github/workflows/release.yml (1 hunks)
✨ Finishing Touches
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Commit Unit Tests in branch ci-tagpr-checkout-token
  • Post Copyable Unit Tests in Comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@5ouma 5ouma merged commit eb5b01e into main Jun 17, 2025
8 of 9 checks passed
@5ouma 5ouma deleted the ci-tagpr-checkout-token branch June 17, 2025 13:26
@5ouma 5ouma bot mentioned this pull request Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎽 CI Changes to CI configuration files and scripts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants