Skip to content

Keep PR is not possible to merge until success#253

Merged
5ouma merged 1 commit intomainfrom
ci-merge-gatekeeper
Jun 14, 2025
Merged

Keep PR is not possible to merge until success#253
5ouma merged 1 commit intomainfrom
ci-merge-gatekeeper

Conversation

@5ouma
Copy link
Owner

@5ouma 5ouma commented Jun 14, 2025

⚠️ Issue

close #


✏️ Description

It observes other workflows' status and prevents unwilling merges.

@5ouma
ci(merge-gatekeeper): Keep PR is not possible to merge until success
7ab2b96 
It observes other workflows' status and prevents unwilling merges.
Copilot AI review requested due to automatic review settings June 14, 2025 12:17
@github-actions github-actions bot added the 🎽 CI Changes to CI configuration files and scripts label Jun 14, 2025
Copilot AI reviewed Jun 14, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a GitHub Actions workflow that blocks pull request merges until all other checks have passed.

  • Introduces a new “Merge Gatekeeper” workflow to enforce successful statuses on merges
  • Configures minimal permissions to read checks and statuses
  • Pins the merge-gatekeeper action to a specific commit
Comments suppressed due to low confidence (1)

.github/workflows/merge-gatekeeper.yml:13

  • The runner label is case-sensitive; replace 'Ubuntu-Latest' with 'ubuntu-latest' to ensure GitHub Actions picks the correct runner.
runs-on: Ubuntu-Latest

@coderabbitai
Copy link

coderabbitai bot commented Jun 14, 2025 •
edited
Loading

Caution

Review failed

Failed to post review comments.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fa760d7 and 7ab2b96.

📒 Files selected for processing (1)
  • .github/workflows/merge-gatekeeper.yml (1 hunks)
🔇 Additional comments (5)
.github/workflows/merge-gatekeeper.yml (5)

1-2: Workflow name is clear and descriptive
The name: 🛡️ Merge Gatekeeper succinctly conveys the purpose of this workflow.

6-6: Validate global permissions scope
An empty permissions: {} removes default scopes. Verify that the job-level permissions sufficiently cover what upsidr/merge-gatekeeper needs (e.g., contents: read, pull-requests: read).

8-9: Job definition is clear
The merge-gatekeeper job is properly declared under jobs.

13-13: Runner selection is appropriate
runs-on: Ubuntu-Latest is standard and well-supported.

16-18: Pinning external action is good practice
Locking upsidr/merge-gatekeeper@09af7a8… to a commit hash avoids unexpected updates. Ensure you review and update this periodically.

Walkthrough

A new GitHub Actions workflow named "Merge Gatekeeper" has been introduced. It runs on pull request events, uses the upsidr/merge-gatekeeper action with specific configuration, and is set to enforce merge policies while ignoring actions by the "CodeRabbit" user or organization.

Changes

File(s) Change Summary
.github/workflows/merge-gatekeeper.yml Added a new workflow to enforce merge gatekeeping on PRs.
✨ Finishing Touches
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Commit Unit Tests in branch ci-merge-gatekeeper
  • Post Copyable Unit Tests in Comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@5ouma 5ouma merged commit 42cb710 into main Jun 14, 2025
9 checks passed
@5ouma 5ouma deleted the ci-merge-gatekeeper branch June 14, 2025 12:23
@5ouma 5ouma bot mentioned this pull request Jun 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@5ouma 5ouma

Labels

🎽 CI Changes to CI configuration files and scripts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@5ouma