Remove the source file argument of Deno lint by 5ouma · Pull Request #231 · 5ouma/reproxy

5ouma · 2025-05-17T07:21:42Z

⚠️ Issue

close #

✏️ Description

Deno lint no longer requires its arguments.

I agree to follow the Code of Conduct.

Deno lint no longer needs its arguments.

Copilot

Pull Request Overview

This PR removes the source file argument from the Deno check command in the CI workflow, as it is no longer required by Deno lint.

Removed the "./src" argument from the "deno check --doc" command in the CI workflow to align with updated Deno lint requirements.

codecov · 2025-05-17T07:22:11Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (391efa6) to head (20d4ffb).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #231   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines           97        97           
  Branches         6         6           
=========================================
  Hits            97        97

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

coderabbitai · 2025-05-17T07:28:14Z

Walkthrough

The GitHub Actions CI workflow was updated by modifying the "Type Check" job. The type checking command was changed from specifying the ./src directory to running without any directory argument, which alters the scope of the type check.

Changes

File(s)	Change Summary
.github/workflows/ci.yml	Updated the "Type Check" job to run `deno check --doc` instead of `deno check --doc ./src`.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 391efa6 and 20d4ffb.

📒 Files selected for processing (1)

.github/workflows/ci.yml (1 hunks)

🔇 Additional comments (1)

.github/workflows/ci.yml (1)

75-75:
Details

❓ Verification inconclusive

Verify type-check scope after removing explicit path
The change drops ./src from the deno check --doc command, so it will default to type-checking all local modules. Please confirm that this matches your intended coverage and doesn’t inadvertently include or omit files.

🏁 Script executed:
#!/usr/bin/env bash
# Compare outputs of type-check with and without explicit path
deno check --doc > /tmp/check_no_arg.txt || true
deno check --doc ./src > /tmp/check_with_arg.txt || true
if ! diff -u /tmp/check_with_arg.txt /tmp/check_no_arg.txt; then
  echo "⚠️ Differences detected in type-check scope"
  exit 1
fi
Length of output: 303
Manual verification of Deno type-check scope required
The sandbox wasn’t able to run deno check, so we couldn’t automatically confirm that dropping ./src didn’t change the set of files being checked. Please run these locally to ensure your CI command covers exactly what you expect:
deno check --doc > /tmp/check_no_arg.txt
deno check --doc ./src > /tmp/check_with_arg.txt
diff -u /tmp/check_with_arg.txt /tmp/check_no_arg.txt
• Verify there are no unexpected differences (new files included or legitimate files omitted).
• If you intended to narrow scope, consider re-adding the explicit path; otherwise, confirm that checking all local modules is correct.

✨ Finishing Touches

🧪 Generate Unit Tests

Create PR with Unit Tests
Commit Unit Tests in branch ci-type-check-arg
Post Copyable Unit Tests in Comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

ci(type-check): Remove the source file argument

20d4ffb

Deno lint no longer needs its arguments.

Copilot AI review requested due to automatic review settings May 17, 2025 07:21

auto-assign bot assigned 5ouma May 17, 2025

Copilot AI reviewed May 17, 2025

View reviewed changes

5ouma changed the title ~~Remove the source file argument~~ Remove the source file argument of Deno lint May 17, 2025

coderabbitai bot approved these changes May 17, 2025

View reviewed changes

5ouma merged commit 924cc84 into main May 17, 2025
15 checks passed

5ouma deleted the ci-type-check-arg branch May 17, 2025 07:28

github-actions bot mentioned this pull request May 15, 2025

Release: v1.4.2 #225

Merged

5ouma added the 🎽 CI Changes to CI configuration files and scripts label May 17, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove the source file argument of Deno lint#231

Remove the source file argument of Deno lint#231
5ouma merged 1 commit intomainfrom
ci-type-check-arg

5ouma commented May 17, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

codecov bot commented May 17, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented May 17, 2025

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

5ouma commented May 17, 2025

⚠️ Issue

✏️ Description

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

codecov bot commented May 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coderabbitai bot commented May 17, 2025

Walkthrough

Changes

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented May 17, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)