src/libs/redirect.test.ts (1)

9-11: Consider adding test cases for edge cases.

While the updates to use testRepo.normal and testRef.normal are good, we could improve test coverage by adding test cases for:

1. Unknown repository (testRepo.unknown)
2. Slash-containing reference (testRef.slash)

This would ensure we're testing all the test data variations we've defined.

Also applies to: 15-21

src/server.test.ts (3)

14-32: Consider test isolation improvements

The exportRepo call affects both test steps but there's no cleanup. Consider:

1. Moving exportRepo into each step for better isolation
2. Adding cleanup after each step to prevent state leakage

 Deno.test("/", async (t: Deno.TestContext) => {
-  exportRepo(testRepo.normal);
   await t.step("Direct", async () => {
+    exportRepo(testRepo.normal);
     const res: Response = await app.request("/");
     assertEquals(res.status, STATUS_CODE.OK);
+    // Cleanup
+    await Deno.remove(testRepo.normal.path, { recursive: true });
   });

   await t.step("Redirect", async () => {
+    exportRepo(testRepo.normal);
     const res: Response = await app.request("/", {
       headers: { "User-Agent": testUserAgent.toString() },
     });
     assertEquals(
       res.headers.get("Location"),
       getGitHubUrl(testRepo.normal).toString(),
     );
     assertEquals(res.status, STATUS_CODE.PermanentRedirect);
+    // Cleanup
+    await Deno.remove(testRepo.normal.path, { recursive: true });
   });
 });

---

56-75: Well-structured test isolation!

This test block demonstrates good practices by:

1. Placing exportRepo within each test step
2. Using appropriate test data structures (testRef.slash)

Consider removing the extra newlines after the request calls (lines 60 and 69) for consistency with other test blocks.

---

13-75: Well-organized test structure improvements

The changes successfully:

1. Organize tests into clear "Direct" and "Redirect" steps
2. Use structured test data consistently (testRepo.normal, testRef.normal/slash)
3. Improve readability and maintainability

This aligns well with the PR's objective of cleaning up test utilities.

Consider documenting these test patterns in a README or contributing guide to ensure consistent test organization across the codebase.

Configuration used: CodeRabbit UI
Review profile: CHILL

src/libs/content.test.ts (1)

Line range hint 8-28: LGTM! Well-structured BDD test organization.

The migration to BDD style using describe/test blocks improves readability and organization. The test cases properly utilize the new structured test objects.

Consider adding descriptions to test cases to document the expected behavior:

-  test("normal", async () => {
+  test("normal - should return OK status and content for valid repo", async () => {
-  test("with ref", async () => {
+  test("with ref - should return OK status and content for valid repo and ref", async () => {
-  test("not found", async () => {
+  test("not found - should return 404 status for unknown repo", async () => {

src/server.test.ts (1)

14-76: Consider reorganizing test structure for better maintainability.

The current structure has some redundancy in the Direct/Redirect test patterns. Consider extracting common test patterns into shared test factories.

Example approach:

const testEndpoint = (path: string, options: { ref?: string }) => {
  describe(`Endpoint: ${path}`, () => {
    beforeEach(() => {
      exportRepo(testRepo.normal);
    });

    test("Direct - should return OK status", async () => {
      const res = await app.request(path);
      assertEquals(res.status, STATUS_CODE.OK);
    });

    test("Redirect - should redirect to GitHub URL", async () => {
      const res = await app.request(path, {
        headers: { "User-Agent": testUserAgent.toString() },
      });
      assertEquals(
        res.headers.get("Location"),
        getGitHubUrl(testRepo.normal, options.ref).toString(),
      );
      assertEquals(res.status, STATUS_CODE.PermanentRedirect);
    });
  });
};

describe("Serve", () => {
  testEndpoint("/", {});
  testEndpoint(`/${testRef.normal}`, { ref: testRef.normal });
  testEndpoint(`/${testRef.slash}`, { ref: testRef.slash });
});

src/server.test.ts (2)

16-16: 🛠️ Refactor suggestion

Refactor repeated exportRepo setup.

The exportRepo setup is duplicated across tests and could lead to flaky tests due to shared state. Consider using beforeEach for setup.

  describe("/", () => {
-    exportRepo(testRepo.normal);
+    beforeEach(() => {
+      exportRepo(testRepo.normal);
+    });
    
    test("Direct", async () => {

Apply similar pattern to other test blocks to ensure clean state for each test.

Also applies to: 37-37, 59-59, 66-66

---

36-36: ⚠️ Potential issue

Fix inconsistent test structure.

Using Deno.test here is inconsistent with the BDD style used elsewhere. Replace with describe to maintain consistency.

-  Deno.test("/:ref", () => {
+  describe("/:ref", () => {

Committable suggestion skipped: line range outside the PR's diff.

src/server.test.ts (2)

19-36: Consider adding edge cases for root path tests

The current test coverage looks good but consider adding tests for:

• Invalid User-Agent headers
• Rate limiting scenarios
• Error responses from GitHub

Example test structure:

test("with invalid User-Agent", async () => {
  const res = await app.request("/", {
    headers: { "User-Agent": "invalid" },
  });
  assertEquals(res.status, STATUS_CODE.BadRequest);
});

---

59-76: Add JSDoc comments explaining slash handling

Consider adding documentation to explain the expected behavior when handling references with slashes.

+ /**
+  * Tests handling of references containing slashes (e.g., feature/branch).
+  * GitHub URLs require special handling for such references.
+  */
  describe("/:ref (with Slash)", () => {

Configuration used: CodeRabbit UI
Review profile: CHILL

#!/bin/bash
# Description: Verify consistent usage of testRef properties

# Check all usages of testRef
rg "testRef\." --type typescript

#!/bin/bash
# Search for testRef usage without file type restriction
rg "testRef\."

# Also search for testRef declaration
ast-grep --pattern 'const testRef = $_'

#!/bin/bash
# Let's find the testRef declaration and its structure
rg "testRef\s*=\s*{" -A 5

# Also check if there are any other properties beyond normal and slash
rg "testRef\.[a-zA-Z]+" --only-matching | sort -u

#!/bin/bash
# Fix the regex to find testRef declaration
rg "testRef = " -A 5

#!/bin/bash
# Search for files that might contain test constants/fixtures
fd "test_" --type f --exec cat {}