Skip to content

Remove GoReleaser config check#352

Merged
5ouma merged 2 commits intomainfrom
ci-ci-remove-goreleaser-check
Dec 6, 2025
Merged

Remove GoReleaser config check#352
5ouma merged 2 commits intomainfrom
ci-ci-remove-goreleaser-check

Conversation

@5ouma
Copy link
Owner

@5ouma 5ouma commented Dec 6, 2025

⚠️ Issue

close #


✏️ Description

The config is checked when dry run release.


The config is checked when dry run release.
Copilot AI review requested due to automatic review settings December 6, 2025 13:27
@github-actions github-actions bot added the 🎽 CI Changes to CI configuration files and scripts label Dec 6, 2025
@codecov
Copy link

codecov bot commented Dec 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 20.44%. Comparing base (e2d9296) to head (521275d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #352   +/-   ##
=======================================
  Coverage   20.44%   20.44%           
=======================================
  Files           9        9           
  Lines         181      181           
=======================================
  Hits           37       37           
  Misses        130      130           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the dedicated goreleaser-check job from the CI workflow, consolidating GoReleaser configuration validation into the existing dry-run-publish job. The dry-run-publish job runs goreleaser release --clean --snapshot, which validates the .goreleaser.yml configuration as part of performing a test build, making a separate check step redundant.

Key Changes:

  • Removed the standalone goreleaser-check job from the CI workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai
Copy link

coderabbitai bot commented Dec 6, 2025

Walkthrough

The GoReleaser verification job has been removed from the CI workflow. The goreleaser-check job and its associated checkout, goreleaser-action steps, and check arguments have been deleted, while all other CI jobs remain unchanged.

Changes

Cohort / File(s) Summary
CI workflow modification
\\.github/workflows/ci.yml
Removed the goreleaser-check job including its checkout and goreleaser-action steps with check arguments. Other jobs (lint-check, format-check, static-analysis, test, dry-run-publish) remain functional.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify that the removal of the goreleaser-check job does not break any dependent workflows or deployment processes
  • Confirm that GoReleaser verification is either not critical or is handled elsewhere in the pipeline
  • Review job ordering to ensure remaining jobs execute correctly without the removed step

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Remove GoReleaser config check' directly and accurately summarizes the main change: deletion of the GoReleaser verification stage from the CI workflow.
Description check ✅ Passed The description explains the rationale for the change, stating that the config is checked during dry run release, which relates to why the separate GoReleaser check job is being removed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ci-ci-remove-goreleaser-check

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e2d9296 and 521275d.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml (0 hunks)
💤 Files with no reviewable changes (1)
  • .github/workflows/ci.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: 🚸 pre-commit
  • GitHub Check: 🛡️ Merge Gatekeeper

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@5ouma 5ouma merged commit 5a86995 into main Dec 6, 2025
14 checks passed
@5ouma 5ouma deleted the ci-ci-remove-goreleaser-check branch December 6, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎽 CI Changes to CI configuration files and scripts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants