Skip to content

Keep PR is not possible to merge until success#315

Merged
5ouma merged 1 commit intomainfrom
ci-merge-gatekeeper
Jun 14, 2025
Merged

Keep PR is not possible to merge until success#315
5ouma merged 1 commit intomainfrom
ci-merge-gatekeeper

Conversation

@5ouma
Copy link
Owner

@5ouma 5ouma commented Jun 14, 2025

⚠️ Issue

close #


✏️ Description

It observes other workflows' status and prevents unwilling merges.

@5ouma
ci(merge-gatekeeper): Keep PR is not possible to merge until success
e997c28 
It observes other workflows' status and prevents unwilling merges.
Copilot AI review requested due to automatic review settings June 14, 2025 14:23
@coderabbitai
Copy link

coderabbitai bot commented Jun 14, 2025 •
edited
Loading

Walkthrough

A new GitHub Actions workflow named "Merge Gatekeeper" was introduced. It runs on pull request events, uses the upsidr/merge-gatekeeper action to enforce merge requirements, and is configured to ignore the user or organization "CodeRabbit."

Changes

File(s) Change Summary
.github/workflows/merge-gatekeeper.yml Added a workflow for pull request events using upsidr/merge-gatekeeper, ignoring "CodeRabbit".
✨ Finishing Touches
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Commit Unit Tests in branch ci-merge-gatekeeper
  • Post Copyable Unit Tests in Comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the 🎽 CI Changes to CI configuration files and scripts label Jun 14, 2025
Copilot AI reviewed Jun 14, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a GitHub Actions workflow to block pull-request merges until all required checks succeed.

  • Adds a new merge-gatekeeper workflow under .github/workflows/
  • Configures minimal permissions and triggers on pull requests
  • Invokes the upsidr/merge-gatekeeper action with a bypass list
Comments suppressed due to low confidence (2)

.github/workflows/merge-gatekeeper.yml:4

  • [nitpick] Specify types: (e.g., opened, synchronize, reopened) under pull_request to limit workflow runs to relevant events and reduce noise.
  pull_request:

.github/workflows/merge-gatekeeper.yml:18

  • [nitpick] Consider using a semantic version tag (e.g., @v1.2.1) instead of a full commit SHA for clearer version management and easier updates.
        uses: upsidr/merge-gatekeeper@09af7a82c1666d0e64d2bd8c01797a0bcfd3bb5d # v1.2.1

coderabbitai[bot]
coderabbitai bot reviewed Jun 14, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/workflows/merge-gatekeeper.yml (2)

3-5: Scope pull request events explicitly.
Consider specifying the pull_request activity types (e.g., types: [opened, reopened, synchronize]) to avoid unnecessary runs on less relevant events.

17-19: Pin action to a specific commit SHA.
Using a fixed SHA ensures stability. Verify periodically that this SHA still corresponds to the intended v1.2.1 release or update as needed.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3406b98 and e997c28.

📒 Files selected for processing (1)
  • .github/workflows/merge-gatekeeper.yml (1 hunks)
🔇 Additional comments (5)
.github/workflows/merge-gatekeeper.yml (5)

1-2: Clear workflow name.
The name accurately reflects the purpose of this workflow.

6-7: Enforced least-privilege permissions.
Setting top-level permissions: {} overrides defaults, granting only the job-specific scopes below.

10-12: Job-level permissions are appropriate.
Granting only checks: read and statuses: read aligns with the action’s need to inspect workflow statuses without elevated rights.

13-14: Runner and timeout configuration looks good.
Ubuntu-Latest and a 10-minute timeout is reasonable for this check.

20-21: Confirm the ignored parameter value.
Ensure ignored: CodeRabbit matches the exact user/organization login to be skipped (including correct casing).

@5ouma 5ouma merged commit effdb3d into main Jun 14, 2025
7 checks passed
@5ouma 5ouma deleted the ci-merge-gatekeeper branch June 14, 2025 14:32
@5ouma 5ouma bot mentioned this pull request Jun 14, 2025
Merged
This was referenced Dec 12, 2025
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

@5ouma 5ouma

Labels

🎽 CI Changes to CI configuration files and scripts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@5ouma