Conversation
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
src/components/PsaBanner/index.tsx
Outdated
| <> | ||
| ⚠️ Safe's new official URL is <a href={NEW_URL}>app.safe.global</a>, with a fully rebranded and refurbished | ||
| application. | ||
| ⚠️ This URL will be deprecated on February the 1st. ⚠️ |
There was a problem hiding this comment.
We should probably specify that it's not just the URL, but also the app. Wdyt?
There was a problem hiding this comment.
I think it's OK as is, because the app is still there, and it's 90% the same. You know it's a new codebase, but to users it's the same app.
Feel free to propose a full alternative piece of text tho.
There was a problem hiding this comment.
The old app will be entirely removed though, right? Therefore, I'd extend it to say "This app and URL..." in line with the previous banner to be as clear as possible.
I will approve this nonetheless.
There was a problem hiding this comment.
How about This is the legacy Safe app which will be deprecated on February the 1st?
Pull Request Test Coverage Report for Build 3873886755
💛 - Coveralls |
What it solves
Update the migration banner with a deprecation date.