Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

style: push Sidebar down the banner height#4091

Merged
DiogoSoaress merged 2 commits intodevfrom
push-sidebar-down
Oct 13, 2022
Merged

style: push Sidebar down the banner height#4091
DiogoSoaress merged 2 commits intodevfrom
push-sidebar-down

Conversation

@DiogoSoaress
Copy link
Contributor

What it solves

Pushes the sidebar a bit down the banner height to be able to click "Load Safe" when banner is shown

How this PR fixes it

Add the banner height to the top property in the sidebar

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Oct 13, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@DiogoSoaress DiogoSoaress marked this pull request as ready for review October 13, 2022 08:48
@coveralls
Copy link

coveralls commented Oct 13, 2022

Pull Request Test Coverage Report for Build 3241071802

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 41.902%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/SafeListSidebar/style.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 3239814329: -0.003%
Covered Lines: 4776
Relevant Lines: 10404

💛 - Coveralls

@DiogoSoaress DiogoSoaress merged commit 35459eb into dev Oct 13, 2022
@DiogoSoaress DiogoSoaress deleted the push-sidebar-down branch October 13, 2022 09:12
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants