fix: handle as named export, Object.defineProperty of exports other than __esModule

59naga · 59naga · commit a1b82d17a0c2 · 2018-07-16T16:43:10.000+09:00
closes #59
diff --git a/src/index.js b/src/index.js
@@ -56,18 +56,20 @@ class ExportsFinder {
       .get('body')
       .forEach(path => {
         if (path.isVariableDeclaration()) {
-          this.findExport(path.get('declarations.0'), 'init')
+          this.findExports(path.get('declarations.0'), 'init')
         } else if (
           path.isExpressionStatement() &&
           path.get('expression').isAssignmentExpression()
         ) {
-          this.findExport(path)
+          this.findExports(path)
+        } else {
+          this.findExportsInCallExpression(path)
         }
       })
     return this.hasExportsDefault && !this.hasExportsNamed && !this.hasModuleExports
   }
 
-  findExport(path, property = 'expression') {
+  findExports(path, property = 'expression') {
     // Not `exports.anything`, skip
     if (!path.get(`${property}.left`).node || !path.get(`${property}.left.object`).node) {
       return
@@ -87,6 +89,24 @@ class ExportsFinder {
     }
   }
 
+  findExportsInCallExpression(path) {
+    const self = this
+    path.traverse({
+      CallExpression(path) {
+        if (!path.get('callee').matchesPattern('Object.defineProperty')) {
+          return
+        }
+
+        const [identifier, prop] = path.get('arguments')
+        const objectName = identifier.get('name').node
+        const propertyName = prop.get('value').node
+        if (objectName === 'exports' && propertyName !== '__esModule') {
+          self.hasExportsNamed = true
+        }
+      }
+    })
+  }
+
   isAmd() {
     const rootPath = this.getRootPath()
     const hasntAmdRoot = !(rootPath.parentPath && rootPath.parentPath.parentPath)
