Merged
Conversation
Without getCollection we get astronomy classes. getCollection() returns plain documents.
derwok
approved these changes
Apr 17, 2018
Member
derwok
left a comment
There was a problem hiding this comment.
Thanks for this QUICK fix! Really looks good!
- Reviewed code with @migerh
- Performed the following manual test with a seeded DB (we'll call this PR === v1.5.2)
- Migrate 1.0.2 => 1.5.2 : OK
- Migrate 1.0.2 => 1.5.0 => 1.5.2 : OK
- Migrate 1.0.2 => 1.5.1 => 1.5.2 : OK
- Migrate 1.0.2 => 1.5.0 => 1.5.1 => 1.5.2 : OK
"OK" means, that I manually & visually checked that all info was still there, I could edit & store old topics, items, details and that "Finalize" worked again.
So when Travis runs green, I'll merge to develop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #437 and repairs databases that were broken by the faulty migration.