Merged
Conversation
Contributor
Author
|
@4meepo PTAL |
Contributor
Author
|
@4meepo, could you take a look and give us an idea of how likely you are to accept this MR and when? We're having an issue with the bug that this MR is fixing. If you object to this PR, we'll have to find another way around it. We won't be able to use |
Owner
|
Been working 996 on another project. And I’m truly sorry for forgetting this PR not once, but twice over these past three months. I really appreciate your patience ❤️ |
Owner
|
@alfa-alex This PR has been merged, and will be build into golang-ci lint automatically, I think. Check it later. |
Contributor
Author
|
All good. 🙂 Thanks for taking care of this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19.
I realized that the
fatih/structtaglibrary used in this project has some functionality that is not needed fortagalignand that can even cause problems. More specifically, it parses the individualOptionsof a struct tag (e.g.,omitemptyforjson:"foo,omitempty") whilst fortagalignit is sufficient to treat the value of a struct tag as a blob.One example of where this additional parsing caused problems could be found in #19.
This PR changes the used
structtaglibrary toalfatraining/structtag, a fork carefully crafted to support exactly the featurestagalignrequires and simplifying the handling of struct values. Given thatfatih/structtaghasn't received any updates since almost three years (with some open MRs unmerged since 2021/22), I hope this change is acceptable. As you can see in this MR, apart from the import change, there is no change required to thetagaligncode.