Import installer scripts and nutconf tool #161

jimklimov · 2022-01-14T15:07:40Z

Got this to build; usability not tested so far (nutconf --help does not crash at least)

C++ style there needs several patterns of face-lift:

g++ -DHAVE_CONFIG_H -I. -I../../include    -I../../include -I../../include -DWITH_NUTSCANNER -I../../tools/nut-scanner -g -O2 -Wno-error -MT nutconf-nutconf.o -MD -MP -MF .deps/nutconf-nutconf.Tpo -c -o nutconf-nutconf.o `test -f 'nutconf.cpp' || echo './'`nutconf.cpp
In file included from ../../include/nutconf.h:24,
                 from nutconf.cpp:26:
../../include/nutstream.hpp:232:24: warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]
  232 |  std::string tmpName() throw(std::runtime_error);
      |                        ^~~~~

In file included from nutconf.cpp:26:
../../include/nutconf.h: In instantiation of 'nut::Settable<Type>& nut::Settable<Type>::operator=(const Type&) [with Type = nut::NutConfiguration::NutMode]':
nutconf.cpp:2085:63:   required from here
../../include/nutconf.h:72:71: warning: no return statement in function returning non-void [-Wreturn-type]
   72 |  Settable<Type>& operator=(const Type& val){_value = val; _set = true;}
      |                                                                       ^
      |                                                                       return *this;

Historic note: effort is related to upstream-NUT feature not merged yet, with networkupstools#6 for context

…_http() => nutscan_scan_xml_http_range()

…use more library paths

…nstall errors)

…015-11-18)

…e (2018)

…rn *this

jimklimov · 2022-01-15T10:18:55Z

Coverage also complains about C++ quality (probably needs to be at least quiesced before PR merge, at best actually solved, to not block builds):

...b_nut_PR-161/tmp/build-coverity/common/nutipc.cpp",
      "type": "Uncaught exception (UNCAUGHT_EXCEPTION)",
      "category": "Error handling issues",
      "severity": "NORMAL",
      "lineStart": "135",
      "lineEnd": "167",
      "message": "A C++ exception is thrown but never caught",
      "description": "root_function: In function <b>nut::Process::Executor::operator ()()</b> an exception of type <b>std::runtime_error</b> is thrown and never caught. <i>(line 135)</i><br>exception_thrown: An exception of type <b>std::runtime_error</b> is thrown. <i>(line 167)</i><br><i>For more information look at Coverity Portal</i>"
    },
    {
      "fileName": "/dev/shm/jenkins-swarm-client/workspace/42ity-github_nut_PR-161/tmp/build-coverity/common/nutstream.cpp",
      "type": "Uncaught exception (UNCAUGHT_EXCEPTION)",
      "category": "Error handling issues",
      "severity": "NORMAL",
      "lineStart": "735",
      "lineEnd": "737",
      "message": "A C++ exception is thrown but never caught",
      "description": "exn_spec_violation: An exception of type <b>std::runtime_error</b> is thrown but the throw list <b>noexcept</b> doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate(). <i>(line 735)</i><br>fun_call_w_exception: Called function throws an exception of type <b>std::runtime_error</b>. <i>(line 737)</i><br><i>For more information look at Coverity Portal</i>"
    },
    {
      "fileName": "/dev/shm/jenkins-swarm-client/workspace/42ity-github_nut_PR-161/tmp/build-coverity/common/nutstream.cpp",
      "type": "Uncaught exception (UNCAUGHT_EXCEPTION)",
      "category": "Error handling issues",
      "severity": "NORMAL",
      "lineStart": "453",
      "lineEnd": "471",
      "message": "A C++ exception is thrown but never caught",
      "description": "root_function: In function <b>nut::NutSocket::Address::Address(std::vector<unsigned char, std::allocator<unsigned char> > const &, uint16_t)</b> an exception of type <b>std::logic_error</b> is thrown and never caught. <i>(line 453)</i><br>exception_thrown: An exception of type <b>std::logic_error</b> is thrown. <i>(line 471)</i><br><i>For more information look at Coverity Portal</i>"
    },
    {
      "fileName": "/dev/shm/jenkins-swarm-client/workspace/42ity-github_nut_PR-161/tmp/build-coverity/common/nutstream.cpp",
      "type": "Uncaught exception (UNCAUGHT_EXCEPTION)",
      "category": "Error handling issues",
      "severity": "NORMAL",
      "lineStart": "616",
      "lineEnd": "652",
      "message": "A C++ exception is thrown but never caught",
      "description": "root_function: In function <b>nut::NutSocket::accept(nut::NutSocket &, nut::NutSocket const &, int &, std::string &)</b> an exception of type <b>std::logic_error</b> is thrown and never caught. <i>(line 616)</i><br>exception_thrown: An exception of type <b>std::logic_error</b> is thrown. <i>(line 652)</i><br><i>For more information look at Coverity Portal</i>"
    },
    {
      "fileName": "/dev/shm/jenkins-swarm-client/workspace/42ity-github_nut_PR-161/tmp/build-coverity/common/nutstream.cpp",
      "type": "Uncaught exception (UNCAUGHT_EXCEPTION)",
      "category": "Error handling issues",
      "severity": "NORMAL",
      "lineStart": "564",
      "lineEnd": "601",
      "message": "A C++ exception is thrown but never caught",
      "description": "root_function: In function <b>_ZNK3nut9NutSocket7Address3strB5cxx11Ev() const</b> an exception of type <b>std::logic_error</b> is thrown and never caught. <i>(line 564)</i><br>exception_thrown: An exception of type <b>std::logic_error</b> is thrown. <i>(line 601)</i><br><i>For more information look at Coverity Portal</i>"
    },
    {
      "fileName": "/dev/shm/jenkins-swarm-client/workspace/42ity-github_nut_PR-161/tmp/build-coverity/common/nutstream.cpp",
      "type": "Uncaught exception (UNCAUGHT_EXCEPTION)",
      "category": "Error handling issues",
      "severity": "NORMAL",
      "lineStart": "93",
      "lineEnd": "106",
      "message": "A C++ exception is thrown but never caught",
      "description": "root_function: In function <b>nut::NutFile::NutFile(nut::NutFile::anonymous_t)</b> an exception of type <b>std::runtime_error</b> is thrown and never caught. <i>(line 93)</i><br>exception_thrown: An exception of type <b>std::runtime_error</b> is thrown. <i>(line 106)</i><br><i>For more information look at Coverity Portal</i>"
    },
    {
      "fileName": "/dev/shm/jenkins-swarm-client/workspace/42ity-github_nut_PR-161/tmp/build-coverity/common/nutstream.cpp",
      "type": "Uncaught exception (UNCAUGHT_EXCEPTION)",
      "category": "Error handling issues",
      "severity": "NORMAL",
      "lineStart": "656",
      "lineEnd": "675",
      "message": "A C++ exception is thrown but never caught",
      "description": "root_function: In function <b>nut::NutSocket::NutSocket(nut::NutSocket::domain_t, nut::NutSocket::type_t, nut::NutSocket::proto_t)</b> an exception of type <b>std::runtime_error</b> is thrown and never caught. <i>(line 656)</i><br>exception_thrown: An exception of type <b>std::runtime_error</b> is thrown. <i>(line 675)</i><br><i>For more information look at Coverity Portal</i>"
    },
    {
      "fileName": "/dev/shm/jenkins-swarm-client/workspace/42ity-github_nut_PR-161/tmp/build-coverity/common/nutstream.cpp",
      "type": "Uncaught exception (UNCAUGHT_EXCEPTION)",
      "category": "Error handling issues",
      "severity": "NORMAL",
      "lineStart": "230",
      "lineEnd": "231",
      "message": "A C++ exception is thrown but never caught",
      "description": "root_function: In function <b>nut::NutFile::NutFile(nut::NutFile::access_t)</b> an exception of type <b>std::runtime_error</b> is thrown and never caught. <i>(line 230)</i><br>fun_call_w_exception: Called function throws an exception of type <b>std::runtime_error</b>. <i>(line 231)</i><br><i>For more information look at Coverity Portal</i>"
    },
    {
      "fileName": "/dev/shm/jenkins-swarm-client/workspace/42ity-github_nut_PR-161/tmp/build-coverity/common/nutstream.cpp",
      "type": "Uncaught exception (UNCAUGHT_EXCEPTION)",
      "category": "Error handling issues",
      "severity": "NORMAL",
      "lineStart": "230",
      "lineEnd": "236",
      "message": "A C++ exception is thrown but never caught",
      "description": "root_function: In function <b>nut::NutFile::NutFile(nut::NutFile::access_t)</b> an exception of type <b>std::runtime_error</b> is thrown and never caught. <i>(line 230)</i><br>fun_call_w_exception: Called function throws an exception of type <b>std::runtime_error</b>. <i>(line 236)</i><br><i>For more information look at Coverity Portal</i>"
    },
    {
      "fileName": "/dev/shm/jenkins-swarm-client/workspace/42ity-github_nut_PR-161/tmp/build-coverity/common/nutipc.cpp",
      "type": "Uncaught exception (UNCAUGHT_EXCEPTION)",
      "category": "Error handling issues",
      "severity": "NORMAL",
      "lineStart": "247",
      "lineEnd": "256",
      "message": "A C++ exception is thrown but never caught",
      "description": "root_function: In function <b>nut::NutSignal::send(nut::Signal::enum_t, std::string const &)</b> an exception of type <b>std::logic_error</b> is thrown and never caught. <i>(line 247)</i><br>fun_call_w_exception: Called function throws an exception of type <b>std::logic_error</b>. <i>(line 256)</i><br><i>For more information look at Coverity Portal</i>"
    },
    {
      "fileName": "/dev/shm/jenkins-swarm-client/workspace/42ity-github_nut_PR-161/tmp/build-coverity/common/nutipc.cpp",
      "type": "Uncaught exception (UNCAUGHT_EXCEPTION)",
      "category": "Error handling issues",
      "severity": "NORMAL",
      "lineStart": "247",
      "lineEnd": "256",
      "message": "A C++ exception is thrown but never caught",
      "description": "root_function: In function <b>nut::NutSignal::send(nut::Signal::enum_t, std::string const &)</b> an exception of type <b>std::runtime_error</b> is thrown and never caught. <i>(line 247)</i><br>fun_call_w_exception: Called function throws an exception of type <b>std::runtime_error</b>. <i>(line 256)</i><br><i>For more information look at Coverity Portal</i>"
    },
    {
      "fileName": "/dev/shm/jenkins-swarm-client/workspace/42ity-github_nut_PR-161/tmp/build-coverity/common/nutwriter.cpp",
      "type": "Uncaught exception (UNCAUGHT_EXCEPTION)",
      "category": "Error handling issues",
      "severity": "NORMAL",
      "lineStart": "126",
      "lineEnd": "130",
      "message": "A C++ exception is thrown but never caught",
      "description": "root_function: In function <b>nut::SectionlessConfigWriter::writeSectionName(std::string const &)</b> an exception of type <b>std::logic_error</b> is thrown and never caught. <i>(line 126)</i><br>exception_thrown: An exception of type <b>std::logic_error</b> is thrown. <i>(line 130)</i><br><i>For more information look at Coverity Portal</i>"
    }
  ]
}

Overall:

Defect occurrences found       : 84 Total
                                  3 CHECKED_RETURN
                                  9 CONSTANT_EXPRESSION_RESULT
                                  3 DEADCODE
                                  1 DELETE_ARRAY
                                  2 FORWARD_NULL
                                  1 NEGATIVE_RETURNS
                                  1 NESTING_INDENT_MISMATCH
                                 16 NULL_RETURNS
                                  1 PATH_MANIPULATION
                                  2 PW.DECLARED_BUT_NOT_REFERENCED
                                  1 PW.NON_CONST_PRINTF_FORMAT_STRING
                                  4 PW.SET_BUT_NOT_USED
                                 10 RESOURCE_LEAK
                                  3 SECURE_CODING
                                  2 SECURE_TEMP
                                 13 UNCAUGHT_EXCEPT
                                  2 UNINIT
                                  9 UNINIT_CTOR
                                  1 UNUSED_VALUE

… impact of nutconf codebase quality by default

…nutconf... for CI farm)

jimklimov · 2022-01-15T13:30:40Z

For now, neutered this by ./configure --with-nutconf required to enable the feature (and currently - grievances for static analysis), so by default this PR does not affect CI builds and packaging.

jimklimov · 2022-01-17T11:24:55Z

Note: the build failures are reported by upstream NUT CI farm check of this PR, since the codebase is not clean enough to pass the "medium" warnings level yet. IPM2 farm is more relaxed and has no qualms with this submission.

...and of IPSS_Unix installer/helper scripts

jimklimov requested a review from aquette January 14, 2022 15:07

jimklimov added 14 commits January 14, 2022 22:06

tools/nut-scanner/Makefile.am: drop extra recipe for nut_version.h

e9a6e61

Add installer scripts from Eaton IPSS Unix 1.40-4 release (2013-10-25)

3a1282f

Import NUT source changes for nutconf tool

e17d156

tools/nutconf/Makefile.am: modernize

a6ed8c8

tools/nutconf/nutconf.cpp: add (C) header

5169448

Add tools/nutconf/.gitignore

d7ce8d4

tools/nutconf/nutconf.cpp: adjust to changed API for nutscan_scan_xml…

3e349e1

…_http() => nutscan_scan_xml_http_range()

Spellcheck manpage for nutconf tool

2ec668a

scripts/installer/install.sh: add logging to trace installer errors; …

dacacf5

…use more library paths

scripts/installer/install.sh: do not dictate a MANPATH (led to some i…

b617699

…nstall errors)

scripts/installer: snapshot from AIX_Clusterware_shutdown delivery (2…

f91bcb8

…015-11-18)

drivers/snmp-ups.h: treat DISABLE_MIB_LOADING more safely

b5c6d91

Stash 0001-Fix-shut-issue-with-UPS-using-PnP-feature.patch

06cc988

Update installer scripts from tentative Eaton IPSS Unix 1.40-5 releas…

c181a4d

…e (2018)

jimklimov force-pushed the FTY-contrib-scripts branch from 6c3e82f to c181a4d Compare January 14, 2022 21:24

jimklimov added 4 commits January 15, 2022 02:02

Merge branch 'FTY' into FTY-contrib-scripts

659de08

nutconf codebase: fix C++17 warnings - dynamic throw() declaration

7d23f19

nutconf codebase: fix C++17 warnings - equality operators should retu…

d106678

…rn *this

eaton-pdu-marlin-mib.c: no ";" needed after func() definition

74ec13f

jimklimov marked this pull request as draft January 15, 2022 10:21

jimklimov added 2 commits January 15, 2022 13:11

tools/nutconf/Makefile.am, tests/Makefile.am, configure.ac: limit the…

1a8284e

… impact of nutconf codebase quality by default

ci_build.sh: add support for CANBUILD_NUTCONF toggle (NUT_BUILD_CAPS=…

a43b1bb

…nutconf... for CI farm)

jimklimov force-pushed the FTY-contrib-scripts branch from 2cfeaa5 to a43b1bb Compare January 15, 2022 12:11

jimklimov marked this pull request as ready for review January 15, 2022 13:29

aquette approved these changes Jan 17, 2022

View reviewed changes

NEWS: Note the contribution of nutconf

169d3c5

...and of IPSS_Unix installer/helper scripts

jimklimov force-pushed the FTY-contrib-scripts branch from fed7ec2 to 169d3c5 Compare January 17, 2022 13:03

Merge branch 'FTY' into FTY-contrib-scripts

117f2da

jimklimov merged commit 4cac998 into 42ity:FTY Jan 19, 2022

jimklimov deleted the FTY-contrib-scripts branch January 19, 2022 10:29

jimklimov mentioned this pull request Jan 24, 2024

FTY remerge from master as of 2024-03-02 networkupstools/nut#2275

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Import installer scripts and nutconf tool #161

Import installer scripts and nutconf tool #161

Uh oh!

jimklimov commented Jan 14, 2022 •

edited

Loading

Uh oh!

jimklimov commented Jan 15, 2022 •

edited

Loading

Uh oh!

jimklimov commented Jan 15, 2022

Uh oh!

jimklimov commented Jan 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Import installer scripts and nutconf tool #161

Import installer scripts and nutconf tool #161

Uh oh!

Conversation

jimklimov commented Jan 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jimklimov commented Jan 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jimklimov commented Jan 15, 2022

Uh oh!

jimklimov commented Jan 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jimklimov commented Jan 14, 2022 •

edited

Loading

jimklimov commented Jan 15, 2022 •

edited

Loading