XML and ASCII parser improvements for reading data from String/Reader#71
Merged
Conversation
Owner
|
Thanks for the contribution 👍 |
|
Anytime 😏
Al’s mail
Saturday, September 17, 2022, 4:19 AM -0600 from ***@***.*** ***@***.***>:
…Thanks for the contribution 👍
—
Reply to this email directly, view it on GitHub , or unsubscribe .
You are receiving this because you are subscribed to this thread. Message ID: <3breadt/dd-plist/pull/71/c1250044310 @ github . com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were no possibility to directly parse an XML or ASCII plist form a String or Reader instance.
Furthermore minor improvements to PropertyListParser were made (e.g. reading a file should not use block size lower than 4K as this is inefficient, 4K is the default block size of most file systems).
Using the constants form
StandardCharsetsinstead of custom Strings saves the charset name parsing.