Fixed MSB4016: An item with the same key has already been added

3F · 3F · commit f2a8a2719396 · 2020-07-20T22:04:32.000+03:00
diff --git a/CI.MSBuild/Initializer.cs b/CI.MSBuild/Initializer.cs
@@ -380,22 +380,24 @@ protected void setCulture(IDictionary<string, string> keys)
         }
 
         /// <summary>
-        /// Extracts arguments by format: 
+        /// Extracts arguments using format:
         /// name1=value1;name2=value2;name3=value3
         /// http://msdn.microsoft.com/en-us/library/ms164311.aspx
         /// </summary>
         /// <param name="raw">Multiple properties separated by semicolon</param>
         /// <returns></returns>
         protected IDictionary<string, string> extractArguments(string raw)
         {
-            if(String.IsNullOrEmpty(raw)) {
+            if(string.IsNullOrWhiteSpace(raw)) {
                 return new Dictionary<string, string>();
             }
 
             return raw.Split(';')
                         .Select(p => p.Split('='))
-                        .Select(p => new KeyValuePair<string, string>(p[0], (p.Length < 2)? null : p[1]))
-                        .ToDictionary(k => k.Key, v => v.Value);
+                        .GroupBy(p => p[0].Trim()) // ... /p:nowarn=1701 /p:nowarn=1702 
+                        .Select(p => p.Last())
+                        .Where(p => !string.IsNullOrWhiteSpace(p[0]))
+                       .ToDictionary(p => p[0].Trim(), p => (p.Length < 2) ? null : p[1]);
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -380,22 +380,24 @@ protected void setCulture(IDictionary<string, string> keys)`
`380`	`380`	`}`
`381`	`381`
`382`	`382`	`/// <summary>`
`383`		`- /// Extracts arguments by format:`
	`383`	`+ /// Extracts arguments using format:`
`384`	`384`	`/// name1=value1;name2=value2;name3=value3`
`385`	`385`	`/// http://msdn.microsoft.com/en-us/library/ms164311.aspx`
`386`	`386`	`/// </summary>`
`387`	`387`	`/// <param name="raw">Multiple properties separated by semicolon</param>`
`388`	`388`	`/// <returns></returns>`
`389`	`389`	`protected IDictionary<string, string> extractArguments(string raw)`
`390`	`390`	`{`
`391`		`- if(String.IsNullOrEmpty(raw)) {`
	`391`	`+ if(string.IsNullOrWhiteSpace(raw)) {`
`392`	`392`	`return new Dictionary<string, string>();`
`393`	`393`	`}`
`394`	`394`
`395`	`395`	`return raw.Split(';')`
`396`	`396`	`.Select(p => p.Split('='))`
`397`		`- .Select(p => new KeyValuePair<string, string>(p[0], (p.Length < 2)? null : p[1]))`
`398`		`- .ToDictionary(k => k.Key, v => v.Value);`
	`397`	`+ .GroupBy(p => p[0].Trim()) // ... /p:nowarn=1701 /p:nowarn=1702`
	`398`	`+ .Select(p => p.Last())`
	`399`	`+ .Where(p => !string.IsNullOrWhiteSpace(p[0]))`
	`400`	`+ .ToDictionary(p => p[0].Trim(), p => (p.Length < 2) ? null : p[1]);`
`399`	`401`	`}`
`400`	`402`	`}`
`401`	`403`	`}`