Import WindowsPhoneDriver as Winium.Silverlight by bayandin · Pull Request #164 · 2gis/Winium.Mobile

bayandin · 2016-10-11T15:15:01Z

Migrate Tests
Service scripts (like PrepareRelease.ps1)
Documentation (at least README)

.Winium.StoreApps.ConnectionInformation.json -> .Winium.Mobile.ConnectionInformation.json

NickAb

Skimmed over the changes. I'll try to take deeper look at this one as soon as on Friday.

NickAb · 2016-10-12T07:26:24Z

Winium/Winium.Mobile.Common/ConnectionInformation.cs

        #region Public Properties

-        public const string FileName = ".Winium.StoreApps.ConnectionInformation.json";
+        public const string FileName = ".Winium.Mobile.ConnectionInformation.json";


I think we should look into backwards compatibility and support both names for a couple of releases. If new file is not found, then it should fallback to the old one and log warning message.

I wouldn't say that this is backwards compatibility issue. Public API wasn't changed. Do we support work for different driver/server versions?
Will have a look at this case later.

I will take a look at this myself. It would be nice to have a gradual transition if it easy to implement. Else we should include some useful message if not connection file was found, so it would be easy to pinpoint the problem of incompatible driver and inner server by end user, who might have messed with versions of inner and outer parts.

NickAb · 2016-10-12T07:27:47Z

Winium/Winium.Mobile.Common/Winium.Mobile.Common.csproj

  <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
  <PropertyGroup>
-    <MinimumVisualStudioVersion>12.0</MinimumVisualStudioVersion>
+    <MinimumVisualStudioVersion>11.0</MinimumVisualStudioVersion>


Why visual studio version has been downgraded? What version of VS did you use to make changes?

Have no idea why VS has decided to downgrade it. It happened when I added target for WP Silverlight 8.1
I use VS Enterprise 2015 (14.0.25431.01 Update 3).

NickAb · 2016-10-12T07:30:00Z

Winium/Winium.Mobile.Common/Winium.Mobile.Common.csproj

-    <TargetFrameworkProfile>Profile151</TargetFrameworkProfile>
-    <TargetFrameworkVersion>v4.6</TargetFrameworkVersion>
+    <TargetFrameworkProfile>Profile259</TargetFrameworkProfile>
+    <TargetFrameworkVersion>v4.5</TargetFrameworkVersion>


Is it because of Silverlight support?

I think so. I'm not an expert in build target in VS I see this and can't change any version:

Could you please try to add target for Silverlight by yourself (you need to replace 89035d8 commit)

I will check this.

NickAb · 2016-10-12T07:33:21Z

Winium/Winium.Mobile.Driver/Automator/Capabilities.cs

            this.PingTimeout = DefaultPingTimeout;
            this.NoFallback = true;
            this.CommandSettings = new CommandSettings();
+            this.IsJavascriptEnabled = true;


Is it required to call ExecuteScript in some selenium bindings? In python selenium bindings do not check this flag at all and allow calling ExecuteScript commands anyway.

It is minor, but will be nice to check this, because it implies javascript support, not some custom "scripting" support.

Ruby client checks that javascript enabled before executing script.
https://github.com/SeleniumHQ/selenium/blob/650a1ab4fe3f0363cde72d8e0202e61e3f713acd/rb/lib/selenium/webdriver/remote/bridge.rb#L620

NickAb · 2016-10-12T07:36:12Z

Winium/Winium.sln

 	EndGlobalSection
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
+		Debug|ARM = Debug|ARM


I don't think we need that much configurations. Visual Studio creates them automatically when any project is added. Need to investigate if that can be prevented in future. Meanwhile, simple deletion of unnecessary configurations will suffice.

I don't mind to remove it, but why do we care about it?

When building Debug or Release configuration it will build for all platforms (x86, arm, anycpu), which is redundant in our case. You will also have to maintain these configuration when adding new projects, etc, because sometime VS does not add new projects to each configuration correctly.

The icing on the cake!

bayandin · 2016-10-17T00:07:06Z

@NickAb ok, it seems it's ready 🎆

NickAb · 2016-10-18T10:13:50Z

@bayandin Thanks, merged 👍

bayandin added 10 commits October 10, 2016 15:44

Prepare project to be merged with winphonedriver

5b2957e

Move InnerServer from winphonedriver

d2cacb6

Fix simple cases

ff41881

Add target WinPhone Silverlight 8.1 to Winium.Common

89035d8

Add invokeMethod from winphonedriver

fcbdf1a

Add invokeAppBarItem from winphonedriver

737198e

Rename InnerDriver -> InnerServer

a4d5f81

Change logic for deviceName matching

df97b89

2gis/winphonedriver#82

Fix reference in tests

d042560

Change *.ConnectionInformation.json filename

df2ff2a

.Winium.StoreApps.ConnectionInformation.json -> .Winium.Mobile.ConnectionInformation.json

NickAb reviewed Oct 12, 2016

View reviewed changes

bayandin and others added 19 commits October 12, 2016 12:51

Cleanup code from outer/inner driver mentions. Bump copyright year

2be1a03

Rename TestApp -> TestApp.StoredApps. Fix references

01ed6a7

Fix returning value for invokeMethod & invokeAppBarItem

1a5fc91

Add TestApp from winphonedriver as TestApp.Silverlight

f291a79

Add functional tests for silverlight server

3f9e1c7

Fix app path for functional tests for silverlight

b92c814

Remove unused configurations

e65d3de

Deprecate fallback to 9998 port and NoFallback capability

f133ca5

Add port and framework info to test apps UI

629ffd0

Fix tests_silverlight to use correct config

c37bac3

Fix TestApp.Silverlight

fe02f4f

Fix InvokeAppBarItem command, refactor ExecuteScript

0e30af2

Fix file ops test for Silverlight

7e1197d

Fix IsDisplayed command on Silverlight

95b7c81

Update tests configs and running scripts

1a6c5f9

Add Winium.Silverlight to service scripts

8e20bbb

Rename output directory Bin\ -> bin\

838a8d9

Mention Winium.Silverlight in READMEs

fc500ab

Add a line to CHANGELOG

09adafe

The icing on the cake!

bayandin changed the title ~~[WIP] Import WindowsPhoneDriver~~ Import WindowsPhoneDriver as Winium.Silverlight Oct 17, 2016

NickAb merged commit 2f18645 into 2gis:master Oct 18, 2016

bayandin deleted the the-merge branch October 18, 2016 10:18

This was referenced Nov 4, 2016

Merge winphonedriver and winium.StoreApps into single project Winium.Mobile #90

Closed

Merge winphonedriver and winium.StoreApps into single project Winium.Mobile 2gis/winphonedriver#53

Closed

Conversation

bayandin commented Oct 11, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NickAb left a comment

Choose a reason for hiding this comment

Uh oh!

NickAb Oct 12, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bayandin Oct 12, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bayandin Oct 12, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bayandin Oct 12, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bayandin commented Oct 17, 2016

Uh oh!

NickAb commented Oct 18, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bayandin commented Oct 11, 2016 •

edited

Loading

NickAb Oct 12, 2016 •

edited

Loading

bayandin Oct 12, 2016 •

edited

Loading

bayandin Oct 12, 2016 •

edited

Loading

bayandin Oct 12, 2016 •

edited

Loading