Speedtest respect user-set core type#8856
Merged
2dust merged 2 commits into2dust:masterfrom Mar 1, 2026
Merged
Conversation
Contributor
DHR60
commented
Feb 27, 2026
- 尊重用户设置的核心类型，将使用该核心测试节点真连接
- 允许测试链式代理连通性，顺带支持了策略组的测试
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the speedtest pipeline to respect each profile’s user-selected core type (Xray vs sing-box) when generating test configs, and extends speedtest config generation to support complex nodes like proxy chains and policy groups.
Changes:
- Enrich
ServerTestItemwith the resolved fullProfileItemand computedCoreTypeso speedtest config generation can use real node data. - Batch speedtests by
CoreTypeinstead of inferring core fromConfigTypelists. - Add
GetProfileItemsByIndexIdsAsMapto reduce repeated lookups and preserve ordering for group child selection.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| v2rayN/ServiceLib/Services/SpeedtestService.cs | Builds ServerTestItem with resolved Profile + CoreType; batches tests by core type. |
| v2rayN/ServiceLib/Services/CoreConfig/V2ray/CoreConfigV2rayService.cs | Allows group types in speedtest config generation; fixes balancer tag usage for routing rules. |
| v2rayN/ServiceLib/Services/CoreConfig/Singbox/CoreConfigSingboxService.cs | Allows group types in speedtest config generation (but currently contains a core support filter issue). |
| v2rayN/ServiceLib/Models/ServerTestItem.cs | Adds Profile (required) and CoreType fields. |
| v2rayN/ServiceLib/Manager/GroupProfileManager.cs | Switches to map-based profile retrieval to preserve requested ordering. |
| v2rayN/ServiceLib/Manager/CoreManager.cs | Chooses speedtest core type from ServerTestItem.CoreType. |
| v2rayN/ServiceLib/Manager/AppManager.cs | Adds GetProfileItemsByIndexIdsAsMap helper. |
| v2rayN/ServiceLib/Handler/CoreConfigHandler.cs | Uses ServerTestItem.Profile directly instead of re-fetching nodes from storage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
v2rayN/ServiceLib/Services/CoreConfig/Singbox/CoreConfigSingboxService.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.