[Security]Add a file extension validation whitelist mapped to an allowed mimetype#262
Closed
BboyKeen wants to merge 1 commit into1up-lab:masterfrom
Closed
[Security]Add a file extension validation whitelist mapped to an allowed mimetype#262BboyKeen wants to merge 1 commit into1up-lab:masterfrom
BboyKeen wants to merge 1 commit into1up-lab:masterfrom
Conversation
Member
|
Thank you! 👍 |
Contributor
|
There is a bug in the current implementation. With the current defined configuration, Symfony's DI component will normalize dashes to underscores in the keys of Example : oneup_uploader:
# ...
allowed_mimetypes:
video/x-msvideo: ['avi']will be translated to : // ...
'allowed_mimetypes' => array(
'video/x_msvideo' => array(
0 => 'avi',
),
),
// ...You need to tell Symfony to not normalize keys by calling Like this : //...
->arrayNode('allowed_mimetypes')
->normalizeKeys(false)
//... |
Member
|
Closed in favor of #289. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
There is no extension check during file upload.
This lack of validation can lead to security problems.
Let's say the configuration contains "image/png" as allowed mimetype
An evil-minded user can upload an HTML page by forging a file beginning with an image header followed by HTML code. This way the uploaded file will pass the mime-type check but will be finally uploaded as HTML file. Then we can use this file as XSS vector to execute javascript.
As recommended in this document https://www.owasp.org/index.php/Unrestricted_File_Upload, I've added an extension whitelist linked to each allowed mimetype.