@bytehead I'm happy to have a look at a PR for SF 5, but in my initial attempts to run the test suite against 4.4 many tests fail because of the signature change for the constructor of Symfony/Component/HttpFoundation/File/UploadedFile.php which between 4.0 and 4.1 went from accepting 6 arguments to only accepting 5 - dropping the size argument.

In 4.x there are attempts made to accommodate this change, but in some cases the parameter types now no-longer match the type hints so tests are failing, and the code which tried to resolve this is completely gone from 5.x.

Thus my question - how do you want to handle this? Given that SF 3.4 is still supported (active support for 11 months, security for 23 months) any change needs to support both the 5 and 6 parameter options. My initial thought is (for example on line 114 of MooUploadController)

if(Kernel::VERSION_ID < 40100) {
    $file = new UploadedFile($tempFile, $uploadFileName, null, null, null, true);
} else {
    $file = new UploadedFile($tempFile, $uploadFileName, null, null, true);
}

Your view?

Sf5 ? #364

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions