Make some columns of the server list view resizable#866
Merged
VShawn merged 2 commits into1Remote:mainfrom Feb 20, 2025
Merged
Conversation
However, there is one problem - it is possible to expand out of the view.
Member
Author
|
Plan changes. Please hold. |
There are still improvements to be made regarding the behavior during and after changing the window width. It is a bit tricky though. I think this is good enough for now.
Member
Author
|
Done. Please check. |
VShawn
reviewed
Feb 19, 2025
| <ColumnDefinition Width="200" SharedSizeGroup="Tags"></ColumnDefinition> | ||
| <ColumnDefinition Width="Auto" SharedSizeGroup="BriefNote" MinWidth="50"></ColumnDefinition> | ||
| <ColumnDefinition Width="{Binding NameWidth}" SharedSizeGroup="Name" MinWidth="50" | ||
| MaxWidth="{Binding NoteWidth, Converter={StaticResource NameMaxWidthConverter}}"></ColumnDefinition> |
Member
There was a problem hiding this comment.
MaxWidth="{Binding NoteWidth, Converter={StaticResource NameMaxWidthConverter}}"
MaxWidth="{Binding NameWidth, Converter={StaticResource NoteMaxWidthConverter}}"
It looks like the two binding target are written in reverse.
Member
Author
There was a problem hiding this comment.
Yes, because NameMaxWidthConverter needs NoteWidth to determine MaxWidth for Name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch is to fix #507.
However, there is one problem - it is possible to expand out of the view.