feat(RDP): add audio quality mode support#551
Merged
VShawn merged 3 commits into1Remote:mainfrom Nov 5, 2023
sparrowhe:feat/quality-audio
Merged
feat(RDP): add audio quality mode support#551VShawn merged 3 commits into1Remote:mainfrom sparrowhe:feat/quality-audio
VShawn merged 3 commits into1Remote:mainfrom
sparrowhe:feat/quality-audio
Conversation
VShawn
requested changes
Nov 5, 2023
Member
VShawn
left a comment
There was a problem hiding this comment.
need to hide the audio quality options when AudioRedirectionMode is not RedirectToLocal
Member
|
感动，这一套逻辑修改、界面修改、国际化词组翻译的流程终于有人跑通并且提交功能性PR了 🌹 ❤️ review 后发现一个小问题， 你看准备你改还是我直接帮你改了？ |
Contributor
Author
|
感谢作者辛勤付出和认可，这也是我第一次参与 C# 开源项目做出贡献，上面提到的小问题我先尝试改一下。 |
VShawn
approved these changes
Nov 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR added audio quality mode support for RDP clinet. Referer https://learn.microsoft.com/en-us/windows/win32/termserv/imsrdpclientadvancedsettings7-audioqualitymode