Add support for excluding macos clipboard items from history#159
Merged
complexspaces merged 4 commits into1Password:masterfrom Aug 27, 2024
bitwarden:mac-exclude-from-history
Merged
Add support for excluding macos clipboard items from history#159complexspaces merged 4 commits into1Password:masterfrom bitwarden:mac-exclude-from-history
complexspaces merged 4 commits into1Password:masterfrom
bitwarden:mac-exclude-from-history
Conversation
complexspaces
requested changes
Aug 24, 2024
Member
There was a problem hiding this comment.
Hey there, thank you for the PR! I apologize for my untimely review. Please rebase this on master to pick up #161 to fix the unrelated CI errors.
I tried this one out locally and the functionality looks good to go! I'm happy to merge this one once the trait rename I've suggested is implemented.
…e-from-history # Conflicts: # src/common.rs
Contributor
Author
|
@complexspaces no worries. I've resolved the review feedback. |
complexspaces
approved these changes
Aug 27, 2024
Member
complexspaces
left a comment
There was a problem hiding this comment.
This looks good to go now, thanks again.
I can most likely make a new release with these changes for you by early next week.
Member
|
This is now released in v3.4.1 on crates.io. Thanks again for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows the Windows strategy of introducing a Set Extension for excluding items from history in MacOS. It's implemented mostly the same way with every set action calling a
add_clipboard_exclusionsfunction.As there isn't technically an official standard it uses the community standard of setting
org.nspasteboard.ConcealedTypefrom http://nspasteboard.org/. I've manually tested this using the Maccy clipboard manager and withexclude_historyitems are no longer tracked.I was a bit uncertain about the naming of the new trait as it could also be called
SetExtMacbut I decided to follow the filename.