Add Get::html on macOS (unimplemented on others)#157
Add Get::html on macOS (unimplemented on others)#157fasterthanlime wants to merge 1 commit into1Password:masterfrom
Conversation
|
Hey there, thanks for the PR. HTML is something we've committed to having it on the platform agnostic main API, so we'd be happy to wrap up that dangling thread by adding a matching
Yeah, its been a few months since that one had any activity. I think that my comment from that PR about where this API should live still feels valid, that its probably best to leave this functionality on the This crate doesn't have an explicit CLA, but I don't think it would be problematic to cherry-pick that PRs commit here and improve on it in more commits for merge if that's something that interests you vs writing X11 from scratch. |
|
I’m not sure how much time I will have to dedicate to this, but for what it’s worth I’m totally fine with this pull request being cannibalized by any further pull request that tackles all four target platforms at once! |
|
Hi, I was looking to get this done primarily on Linux, but I can also delve into how to implement it for other platforms too. |
No problem at all, please do! |
So this is half-baked since it panics on non-macOS platforms, but I can work on finishing it up if that's something y'all are willing to bear the burden of maintaining long-term.
If not, it'll just live in a fork of mine! Let me know!
(also just noticing #130 now)