Skip to content

fix: Add margin to "View comparison" button and fix "Use custom version" button color issue #9905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ssongliu merged 2 commits into from
Aug 9, 2025
Merged

fix: Add margin to "View comparison" button and fix "Use custom version" button color issue #9905

ssongliu merged 2 commits into from
Aug 9, 2025

Conversation

@wangdage12
Copy link
Contributor

@wangdage12 wangdage12 commented Aug 7, 2025 •
edited
Loading

What this PR does / why we need it?

This PR adds margin to the "View comparison" button on the App upgrade page to improve visual layout, and fixes the color issue of the "Use custom version" button on the comparison view.

old:
old

new:
new

Summary of your change

  • Added spacing (margin) to the "View comparison" button.

  • Fixed the button color issue for "Use custom version" on the comparison page, ensuring it behaves correctly on hover and click.

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
    UI-only fix.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.
    Not applicable (UI-only fix).

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Aug 7, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Aug 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ssongliu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ssongliu
Copy link
Member

ssongliu commented Aug 8, 2025

感谢贡献！

出于兼容性考虑，这里最好是直接去掉 type=success。因为咱们系统支持主题色自定义，使用固定颜色可能在某些主题色下不合适。

另外 style="margin-top: 12px" 建议改为 class="mt-2"

@wangdage12
Copy link
Contributor Author

wangdage12 commented Aug 8, 2025

感谢贡献！

出于兼容性考虑，这里最好是直接去掉 type=success。因为咱们系统支持主题色自定义，使用固定颜色可能在某些主题色下不合适。

另外 style="margin-top: 12px" 建议改为 class="mt-2"

好的，另外去掉type=success之后可能容易点错，我觉得可以将使用自定义版本按钮改为primary按钮，这样可以吗
PixPin_2025-08-08_21-04-45

@ssongliu
Copy link
Member

ssongliu commented Aug 9, 2025

感谢贡献！

出于兼容性考虑，这里最好是直接去掉 type=success。因为咱们系统支持主题色自定义，使用固定颜色可能在某些主题色下不合适。

另外 style="margin-top: 12px" 建议改为 class="mt-2"

好的，另外去掉type=success之后可能容易点错，我觉得可以将使用自定义版本按钮改为primary按钮，这样可以吗
PixPin_2025-08-08_21-04-45

可以的！

@ssongliu ssongliu merged commit 2be7054 into 1Panel-dev:dev-v2 Aug 9, 2025
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ssongliu ssongliu Awaiting requested review from ssongliu

@zhengkunwang223 zhengkunwang223 Awaiting requested review from zhengkunwang223

Assignees

No one assigned

Labels

do-not-merge/release-note-label-needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wangdage12 @ssongliu