Skip to content

feat: Implement connection closure handling in status 444 #11574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhengkunwang223 merged 2 commits into from
Jan 6, 2026
Merged

feat: Implement connection closure handling in status 444 #11574

zhengkunwang223 merged 2 commits into from
Jan 6, 2026

Conversation

@HynoR
Copy link
Contributor

@HynoR HynoR commented Jan 6, 2026 •
edited
Loading

What this PR does / why we need it?

#11450

Summary of your change

ref

1Panel/agent/middleware/certificate.go

Lines 41 to 51 in ef6e342

func CloseDirectly(c *gin.Context) {
hijacker, ok := c.Writer.(http.Hijacker)
if !ok {
c.AbortWithStatus(http.StatusForbidden)
return
}
conn, _, err := hijacker.Hijack()
if err != nil {
c.AbortWithStatus(http.StatusForbidden)
return
}

把agent 里的 CloseDirectly 改改直接搬到 core里用，我们不生产代码，我们只是代码的搬运工
截屏2026-01-06 15 32 45

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jan 6, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jan 6, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wanghe-fit2cloud for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhengkunwang223 zhengkunwang223 merged commit f67bdf0 into 1Panel-dev:dev-v2 Jan 6, 2026
0 of 3 checks passed
@HynoR HynoR deleted the pr@ff branch January 6, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ssongliu ssongliu Awaiting requested review from ssongliu

@zhengkunwang223 zhengkunwang223 Awaiting requested review from zhengkunwang223

Assignees

No one assigned

Labels

do-not-merge/release-note-label-needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HynoR @zhengkunwang223