Skip to content

Conversation

@Kadxy
Copy link
Contributor

@Kadxy Kadxy commented Dec 10, 2025

What this PR does / why we need it?

This improvement allows password managers to detect the field as a OTP input and allows auto-fill the verification code directly from the browser extension or keyboard suggestions.

Summary of your change

Add autocomplete="one-time-code" to the MFA login input field in frontend/src/views/login/components/login-form.vue.

image

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

Copilot AI review requested due to automatic review settings December 10, 2025 19:17
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 10, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wanghe-fit2cloud for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the MFA login experience by adding the autocomplete="one-time-code" attribute to the MFA verification code input field. This allows password managers and browser extensions to automatically detect and autofill OTP codes.

  • Add autocomplete="one-time-code" attribute to the MFA input field for better browser integration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Kadxy Kadxy changed the title feat(frontend): add autocomplete attributes for MFA input feat: add autocomplete attributes for MFA input Dec 10, 2025
@zhengkunwang223 zhengkunwang223 merged commit 8606427 into 1Panel-dev:dev-v2 Dec 11, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants