Skip to content

Conversation

@HynoR
Copy link
Contributor

@HynoR HynoR commented Dec 5, 2025

What this PR does / why we need it?

优化获取ssh session逻辑的执行顺序和检测方案,减少不必要开销

Summary of your change

  • 先去过滤出符合条件的用户信息,确认有需要找 pid的用户再执行process.Processes()这个有开销的函数, 而不是先去查 process
  • 把 proc.cmdLine 移出循环,只需要执行一次拿到值就够了
  • 用 map 预存 host,直接通过 map[connect 的 IP] 来看是否命中

测试返回数据均不变
image

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 5, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zhengkunwang223 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhengkunwang223 zhengkunwang223 merged commit bb72ea0 into 1Panel-dev:dev-v2 Dec 8, 2025
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants