Skip to content

perf: remove useless stat checking logic #11178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhengkunwang223 merged 2 commits into from
Dec 4, 2025
Merged

perf: remove useless stat checking logic #11178

zhengkunwang223 merged 2 commits into from
Dec 4, 2025

Conversation

@HynoR
Copy link
Contributor

@HynoR HynoR commented Dec 4, 2025

What this PR does / why we need it?

每一个请求都stat一遍有点太浪费了，而且没有必要。

Summary of your change

移除os.stat，换成超时 dial 逻辑，超时即报 502 错误。测试 agent 挂掉时这个新逻辑不影响 core，agent再启动也没有影响

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

HynoR added 2 commits December 4, 2025 13:19
@HynoR
feat: Enhance proxy initialization and error handling
3a00bcb 
* Add a timeout to the dialer for Unix socket connections
* Improve error response by including the error message in the "Bad Gateway" response
@HynoR
refactor: Change sockPath variable to constant in proxy initialization
a47261f 
* Update sockPath to a constant SockPath for improved clarity and consistency
* Ensure the new constant is used in the dialer function for Unix socket connections
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 4, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zhengkunwang223 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HynoR HynoR changed the title perf: remove useless stat check logic perf: remove useless stat checking logic Dec 4, 2025
@HynoR HynoR marked this pull request as draft December 4, 2025 05:49
@HynoR HynoR marked this pull request as ready for review December 4, 2025 05:52
@f2c-ci-robot f2c-ci-robot bot requested a review from ssongliu December 4, 2025 05:52
@zhengkunwang223 zhengkunwang223 merged commit 781155b into 1Panel-dev:dev-v2 Dec 4, 2025
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wanghe-fit2cloud wanghe-fit2cloud Awaiting requested review from wanghe-fit2cloud

@zhengkunwang223 zhengkunwang223 Awaiting requested review from zhengkunwang223

@ssongliu ssongliu Awaiting requested review from ssongliu

Assignees

No one assigned

Labels

do-not-merge/release-note-label-needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HynoR @zhengkunwang223