Skip to content

Conversation

@HynoR
Copy link
Contributor

@HynoR HynoR commented Nov 27, 2025

What this PR does / why we need it?

image

直接读取文件时,会把文件内容拷贝到 content ,此时会有 2m 内存 (应用商店信息的json文件大小),然后内存中的 content再被反序列化内容。
可以直接用 decoder 一步读文件并反序列化,省掉这个拷贝操作。节约 2m 内存

Summary of your change

更换流 decoder 方法,直接让 decoder 读文件解析出内容。节约流程中在堆上占用 2m 的内存, 解析流程不变。

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Nov 27, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Nov 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wanghe-fit2cloud for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HynoR HynoR changed the title fix: Improve app list loading by using JSON decoder from file stream fix: improve applist loading by using JSON decoder from file stream Nov 27, 2025
@wanghe-fit2cloud wanghe-fit2cloud merged commit 74b48a1 into 1Panel-dev:dev-v2 Nov 27, 2025
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants