Skip to content

refactor: Optimize log file reading logic #11064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wanghe-fit2cloud merged 3 commits into from
Nov 25, 2025
Merged

refactor: Optimize log file reading logic #11064

wanghe-fit2cloud merged 3 commits into from
Nov 25, 2025

Conversation

@HynoR
Copy link
Contributor

@HynoR HynoR commented Nov 25, 2025 •
edited
Loading

What this PR does / why we need it?

优化日志读取算法

Summary of your change

ReadFileByLine 用环形缓冲队列来统计行，而不是全读一遍。减少一遍全量读写
TailFromEnd 直接后插，最后再翻转过来，减少每次前插的内存开销。
使用sync.pool而不是循环new来麻烦GC

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Nov 25, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@HynoR HynoR marked this pull request as draft November 25, 2025 04:51
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Nov 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wanghe-fit2cloud for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HynoR HynoR marked this pull request as ready for review November 25, 2025 07:54
@HynoR HynoR changed the title (draft) refactor: Optimize log file reading logic refactor: Optimize log file reading logic Nov 25, 2025
@wanghe-fit2cloud wanghe-fit2cloud merged commit b416e6b into 1Panel-dev:dev-v2 Nov 25, 2025
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ssongliu ssongliu Awaiting requested review from ssongliu

@zhengkunwang223 zhengkunwang223 Awaiting requested review from zhengkunwang223

@wanghe-fit2cloud wanghe-fit2cloud Awaiting requested review from wanghe-fit2cloud

Assignees

No one assigned

Labels

do-not-merge/release-note-label-needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HynoR @wanghe-fit2cloud