Skip to content

feat: add firewall rule import/export with JSON validation and alerts #10706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wanghe-fit2cloud merged 3 commits into from
Oct 22, 2025
Merged

feat: add firewall rule import/export with JSON validation and alerts #10706

wanghe-fit2cloud merged 3 commits into from
Oct 22, 2025

Conversation

@HynoR
Copy link
Contributor

@HynoR HynoR commented Oct 20, 2025 •
edited
Loading

What this PR does / why we need it?

#10702

Summary of your change

  • Implemented import dialog for firewall rules in the forward, IP, and port sections.
  • Introduced export functionality to download current firewall rules as JSON files.
  • Added support for JSON file uploads to import firewall rules, with validation and conflict detection.
  • Enhanced user feedback with alerts for new, conflicting, and duplicate rules during import.
  • Updated translations for new import-related messages in multiple languages (pt-br, ru, tr, zh-Hant, zh).

PS: translation work and a small amount of code lines was generated by AI coding tools.

Test Result

image image image

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 20, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zhengkunwang223 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wanghe-fit2cloud
Copy link
Member

wanghe-fit2cloud commented Oct 22, 2025

感谢支持。

@wanghe-fit2cloud wanghe-fit2cloud merged commit f462591 into 1Panel-dev:dev-v2 Oct 22, 2025
0 of 3 checks passed
@HynoR HynoR deleted the feat/ip2 branch November 6, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ssongliu ssongliu Awaiting requested review from ssongliu

@wanghe-fit2cloud wanghe-fit2cloud Awaiting requested review from wanghe-fit2cloud

Assignees

No one assigned

Labels

do-not-merge/release-note-label-needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HynoR @wanghe-fit2cloud