Conversation
|
I wonder if there's value in leaving a reference to it for developers who don't have mature dotfiles/want to see how others have set up their computers in the past? I just onboarded and while I didn't end up using the laptop script, I did look through it to see if there was anything configuration or software in particular that was preferred, and thought it was nice to look through! |
|
I added some other folks that have either made comments within Slack or GitHub Issues/Pull Requests in the last year to make sure they have visibility into this as well. I noticed not all of them have given the 👍 so given them a chance to also give a 👎 or leave a comment. |
|
@Sgtpluck That's a really good point. We should capture those recommendations and get them into the handbook or the engineering guide. I think things like a preference for environment/version manager ( |
|
Not hearing any objections, going to go ahead and merge this. If someone wants to incorporate recommendations into the Engineering Guide, by all means! |
The laptop script has been long un[der]maintained, and I think has been completely broken for at least a year. This is taking the proposal from 18F/laptop#189 a step further: since there's no ability to maintain it (right now), we should stop confusing new hires and take it out of the onboarding steps.
Side note: preventing committing secrets is the part of the script that I do believe should be a requirement for anyone interacting with Git. I am talking with the Mac Working Group about having that on our Macs by default. This is a much better way to ensure consistency. cc 18F/laptop#185
If you agree with this change, please leave a 👍 emoji vote. If you disagree, please leave a comment, or send me a message on Slack. I'll wait to merge until it seems there is consensus. Thanks!
Follow-up TODOs