Bump priority in hook to make webp conversion works#231
Merged
jeffpaul merged 1 commit into10up:developfrom Jun 17, 2024
Merged
Bump priority in hook to make webp conversion works#231jeffpaul merged 1 commit into10up:developfrom
jeffpaul merged 1 commit into10up:developfrom
Conversation
Collaborator
|
@hugosolar Simple yet effective update. Approved. cc @jeffpaul |
rickalee
approved these changes
Jun 14, 2024
Member
|
@hugosolar I'm noting now that this PR had e2e failures as does #230, so hoping you can look into that either in a new PR or perhaps updated on #230? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
this change closes #191
I was able to investigate this issue and enabling performance lab and enable webp option causes the plugin just uploads
webpconverted images from intermediate images excluding the original.Because of this plugin uses
wp_generate_attachment_metadatahook to upload images to blob container, there seems to be a priority conflict with WordPress native conversion from the original image at the moment of uploading to the container.Increasing the hook priority to 10, make the plugin work as expected and upload the
webpconverted original image and also the original image itself which is the expected behavior (as referred by the official documentation).After uploading to the blob container and checked the meta data I'm able to see the original jpeg image is kept into the meta field
Also, the
windows_azure_storage_infoattachment meta field is keeping both imagesHow to test the Change
_wp_attachment_metadatawindows_azure_storage_info_wp_attached_fileshould point to the webp original versionChangelog Entry
Credits
@hugosolar, @ali-awwad (for reporting it)
Checklist: