Skip to content

Bump WordPress "tested up to" version 6.8#336

Merged
jeffpaul merged 1 commit intotrunkfrom
bump/wp-ver-trunk
Apr 24, 2025
Merged

Bump WordPress "tested up to" version 6.8#336
jeffpaul merged 1 commit intotrunkfrom
bump/wp-ver-trunk

Conversation

@jeffpaul
Copy link
Copy Markdown
Member

Description of the Change

Cherry-picks changes from #335 to trunk to trigger the Readme Updater action and update things over at dotorg.

Closes #334.

How to test the Change

Already tested via #334 (comment).

Changelog Entry

n/a

Credits

n/a

Checklist:

@jeffpaul jeffpaul added this to the 2.0.0 milestone Apr 24, 2025
@jeffpaul jeffpaul self-assigned this Apr 24, 2025
@jeffpaul jeffpaul requested a review from a team as a code owner April 24, 2025 20:14
@jeffpaul jeffpaul requested review from Sidsector9 and removed request for a team April 24, 2025 20:14
@jeffpaul jeffpaul linked an issue Apr 24, 2025 that may be closed by this pull request
@jeffpaul jeffpaul merged commit b37148d into trunk Apr 24, 2025
3 checks passed
@jeffpaul jeffpaul deleted the bump/wp-ver-trunk branch April 24, 2025 20:18
@jeffpaul
Copy link
Copy Markdown
Member Author

Bah somehow the POT file was modified: https://github.com/10up/simple-podcasting/actions/runs/14650881078.

@jeffpaul
Copy link
Copy Markdown
Member Author

So the readme updater does this:

which breaks down to this:
https://github.com/10up/simple-podcasting/blob/1eed5eeb2c9a58dfae22b13a6911bb7b468858a2/package.json#L22C1-L22C33

which seems ok, but perhaps if that runs prebuild then the issue with makepot will creep in:

"prebuild": "npm run makepot",

So perhaps a more custom build step in the action here @dkotter?

@dkotter
Copy link
Copy Markdown
Collaborator

dkotter commented Apr 25, 2025

So perhaps a more custom build step in the action here @dkotter?

I think same approach as mentioned here: 10up/simple-page-ordering#240 (comment), will work, basically separating npm run makepot as a command we directly run when needed and not as part of the build or prebuild workflow

@dkotter dkotter modified the milestones: 2.0.0, 1.9.1 May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The plugin hasn't been tested with the latest version of WordPress

2 participants