Feature/issue 83 latest episode block#266
Conversation
|
@barneyjeffries thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this? |
|
@barneyjeffries thanks for the PR, can you please check the PHPCS issues and fix it? https://github.com/10up/simple-podcasting/actions/runs/7397681115/job/20125248325 |
faisal-alvi
left a comment
There was a problem hiding this comment.
I will continue the review after the PHPCS issues are addressed, thanks!
|
@faisal-alvi yes of course - sorry meant to check these before |
|
@barneyjeffries thanks for the fixes, the cypress test if failing for the WP minimum. I tried re-running the test but it failed again. Can you please check? https://github.com/10up/simple-podcasting/actions/runs/7477805060/job/20488930685 |
|
@faisal-alvi @jeffpaul I think we should pause on CR for this PR as I'm working on the Player enhancements which will supersede this change. |
|
@faisal-alvi @jeffpaul Apologies, I got confused with the 'Listen Time' task - this task is not related to the Player Enhancements. I will into the tests and why they are failing. |
|
@faisal-alvi @jeffpaul I've run the tests locally and the block test is working correctly - I have had this before with Cypress, but I don't think anything in this PR should have affected these existing tests. |
faisal-alvi
left a comment
There was a problem hiding this comment.
LGTM, thanks for working on this.
BE:
FE:
Description of the Change
Added variation based on Query Loop for Latest Episode
Closes #83
Alternate Designs
Possible Drawbacks
Verification Process
Checklist:
Changelog Entry
Credits
Props @