feat/154: add a Podcast Platforms Block#241
Merged
Sidsector9 merged 13 commits intodevelopfrom Aug 18, 2023
Merged
Conversation
Member
Author
|
@iamdharmesh this is ready for your review. |
iamdharmesh
requested changes
Aug 8, 2023
Member
iamdharmesh
left a comment
There was a problem hiding this comment.
Thank you for the PR and great work here @Sidsector9. Just added 2-3 minor notes to discuss other wise all good.
Thanks
| 'type' => 'platform_fields', | ||
| ), | ||
| array( | ||
| 'slug' => 'podcasting_icon_theme', |
Member
There was a problem hiding this comment.
Nitpick:
I think keeping the icon theme option at block level is more user-friendly. Not a major issue, but love to hear your thoughts on this.
Member
Author
There was a problem hiding this comment.
@iamdharmesh that's a good idea, but something we can iteratively implement?
Member
There was a problem hiding this comment.
Sure @Sidsector9, maybe we should create a follow-up issue for this?
iamdharmesh
reviewed
Aug 18, 2023
iamdharmesh
approved these changes
Aug 18, 2023
Member
iamdharmesh
left a comment
There was a problem hiding this comment.
Thank you for the changes @Sidsector9, LGTM!
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #154
Description of the Change
This PR adds the Podcast Platforms block.
Podcasting Platforms block
Podcasting Platforms settings
Verification Process
Checklist:
Changelog Entry
Credits
Props @jeffpaul @Sidsector9